Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: 57262eb)
arm_semihosting: fix two dead assignments 89/6589/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Wed, 22 Sep 2021 16:59:38 +0000 (18:59 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Mon, 25 Oct 2021 16:09:12 +0000 (16:09 +0000)
Clang scan-build complains for two dead assignments:
Value stored to 'r' is never read

Use the variable in the following line, instead of re-computing
the pointer.

Change-Id: I5d4069872be9da85fb28bbe0a82020b90f1efe46
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6589
Tested-by: jenkins
src/target/arm_semihosting.c patch | blob | history

diff --git a/src/target/arm_semihosting.c b/src/target/arm_semihosting.c
index 1e5b5e25206f9ce75fad57bafd8cbfdc8c436f51..792474acf0de7eb66a5b3cadce4f20ddaf45f2bf 100644 (file)
--- a/src/target/arm_semihosting.c
+++ b/src/target/arm_semihosting.c
@@ -315,7 +315,7 @@ int arm_semihosting(struct target *target, int *retval)
                                return 0;
                } else if (arm->core_state == ARM_STATE_ARM) {
                        r = arm->pc;
-                       pc = buf_get_u32(arm->pc->value, 0, 32);
+                       pc = buf_get_u32(r->value, 0, 32);
 
                        /* A32 instruction => check for HLT 0xF000 (0xE10F0070) */
                        uint32_t insn = 0;
@@ -330,7 +330,7 @@ int arm_semihosting(struct target *target, int *retval)
                                return 0;
                } else if (arm->core_state == ARM_STATE_THUMB) {
                        r = arm->pc;
-                       pc = buf_get_u32(arm->pc->value, 0, 32);
+                       pc = buf_get_u32(r->value, 0, 32);
 
                        /* T32 instruction => check for HLT 0x3C (0xBABC) */
                        uint16_t insn = 0;
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)