riscv: fix compile error 56/5856/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Wed, 14 Oct 2020 08:41:12 +0000 (10:41 +0200)
committerAntonio Borneo <borneo.antonio@gmail.com>
Wed, 14 Oct 2020 10:05:22 +0000 (11:05 +0100)
The commit b68674a1da72 ("Upstream tons of RISC-V changes.") was
proposed well before commit 3ac010bb9f10 ("Fix debug prints when
loading to flash"), but the merge got in different order.
After latest merge, the master branch fails to compile.

Fix the compile error.

Change-Id: Ia3bd21d970d589343a3b9b2d58c89e0c49f30015
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5856
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
Reviewed-by: Jan Matyas <matyas@codasip.com>
src/target/riscv/riscv.c

index 4ef969b016a2c43bc828c8fc466c943602b08d93..53af07ec31ad97fd5264f55fc1a62014abc578b6 100644 (file)
@@ -3452,7 +3452,7 @@ static int register_get(struct reg *reg)
                buf_set_u64(reg->value, 0, reg->size, value);
        }
        reg->valid = gdb_regno_cacheable(reg->number, false);
-       char *str = buf_to_str(reg->value, reg->size, 16);
+       char *str = buf_to_hex_str(reg->value, reg->size);
        LOG_DEBUG("[%d]{%d} read 0x%s from %s (valid=%d)", target->coreid,
                        riscv_current_hartid(target), str, reg->name, reg->valid);
        free(str);
@@ -3465,7 +3465,7 @@ static int register_set(struct reg *reg, uint8_t *buf)
        struct target *target = reg_info->target;
        RISCV_INFO(r);
 
-       char *str = buf_to_str(buf, reg->size, 16);
+       char *str = buf_to_hex_str(buf, reg->size);
        LOG_DEBUG("[%d]{%d} write 0x%s to %s (valid=%d)", target->coreid,
                        riscv_current_hartid(target), str, reg->name, reg->valid);
        free(str);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)