rtos: add custom stack read function 42/7442/2
authorErhan Kurubas <erhan.kurubas@espressif.com>
Sat, 21 Jan 2023 19:10:21 +0000 (20:10 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 28 Jan 2023 15:50:50 +0000 (15:50 +0000)
This is optional field for the targets which has to implement
their custom stack read function.

Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
Change-Id: Icbc9ed66a052fc2cc0ef67e3ec4d85ab0c2c1b94
Reviewed-on: https://review.openocd.org/c/openocd/+/7442
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/rtos/rtos.c
src/rtos/rtos.h

index 2e76b501ae26816e311d86bcc02f4f51152073f7..dfa158d016012e3eb54c2da0b96e3ab683f66ca9 100644 (file)
@@ -632,7 +632,10 @@ int rtos_generic_stack_read(struct target *target,
 
        if (stacking->stack_growth_direction == 1)
                address -= stacking->stack_registers_size;
-       retval = target_read_buffer(target, address, stacking->stack_registers_size, stack_data);
+       if (stacking->read_stack)
+               retval = stacking->read_stack(target, address, stacking, stack_data);
+       else
+               retval = target_read_buffer(target, address, stacking->stack_registers_size, stack_data);
        if (retval != ERROR_OK) {
                free(stack_data);
                LOG_ERROR("Error reading stack frame from thread");
index ace57514af5044dbd80ce5f590e53ac53a7b982c..9128c163c7238aa3fe4be2864adfebc984d165ac 100644 (file)
@@ -102,6 +102,13 @@ struct rtos_register_stacking {
                const struct rtos_register_stacking *stacking,
                target_addr_t stack_ptr);
        const struct stack_register_offset *register_offsets;
+       /* Optional field for targets which may have to implement their own stack read function.
+        * Because stack format can be weird or stack data needed to be edited before passing to the gdb.
+        */
+       int (*read_stack)(struct target *target,
+               int64_t stack_ptr,
+               const struct rtos_register_stacking *stacking,
+               uint8_t *stack_data);
 };
 
 #define GDB_THREAD_PACKET_NOT_CONSUMED (-40)

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)