Correct argument numbering in trace command 00/1800/2
authorAlan Bowman <alan.michael.bowman@gmail.com>
Tue, 5 Nov 2013 22:25:51 +0000 (22:25 +0000)
committerSpencer Oliver <spen@spen-soft.co.uk>
Wed, 6 Nov 2013 12:59:04 +0000 (12:59 +0000)
The trace command was opening a file named with the source frequency.
This change correctly passes the filename that is specified.

Change-Id: Ia2eb8eda0e1e0f4f44b05c3a0ce7bef3bda51446
Signed-off-by: Alan Bowman <alan.michael.bowman@gmail.com>
Reviewed-on: http://openocd.zylin.com/1800
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/jtag/hla/hla_interface.c

index ae33f54e08d4aeab62ebc4ab29d737e53be7a416..919313300576e932e14debb749d027a03439c0ce 100644 (file)
@@ -243,7 +243,7 @@ COMMAND_HANDLER(interface_handle_trace_command)
        }
 
        if (CMD_ARGC == 2) {
        }
 
        if (CMD_ARGC == 2) {
-               f = fopen(CMD_ARGV[0], "a");
+               f = fopen(CMD_ARGV[1], "a");
                if (!f)
                        return ERROR_COMMAND_SYNTAX_ERROR;
        }
                if (!f)
                        return ERROR_COMMAND_SYNTAX_ERROR;
        }

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)