debug: make logging of commands terser
authorØyvind Harboe <oyvind.harboe@zylin.com>
Mon, 11 Jan 2010 14:54:52 +0000 (15:54 +0100)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Wed, 13 Jan 2010 07:32:15 +0000 (08:32 +0100)
one line / command instead of one line per argument.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
src/helper/command.c

index cf66f8a4c701a2c402a4133880e294ca76441f9d..ebd9aa6265b8c674c07a1f45ca7246f39a0ad327 100644 (file)
@@ -108,10 +108,15 @@ static int command_retval_set(Jim_Interp *interp, int retval)
 
 extern struct command_context *global_cmd_ctx;
 
+/* dump a single line to the log for the command.
+ * Do nothing in case we are not at debug level 3 */
 void script_debug(Jim_Interp *interp, const char *name,
                unsigned argc, Jim_Obj *const *argv)
 {
-       LOG_DEBUG("command - %s", name);
+       if (debug_level < LOG_LVL_DEBUG)
+               return;
+
+       char * dbg = alloc_printf("command - %s", name);
        for (unsigned i = 0; i < argc; i++)
        {
                int len;
@@ -121,8 +126,12 @@ void script_debug(Jim_Interp *interp, const char *name,
                if (*w == '#')
                        break;
 
-               LOG_DEBUG("%s - argv[%d]=%s", name, i, w);
+               char * t = alloc_printf("%s %s", dbg, w);
+               free (dbg);
+               dbg = t;
        }
+       LOG_DEBUG("%s", dbg);
+       free(dbg);
 }
 
 static void script_command_args_free(const char **words, unsigned nwords)

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)