target: LS1_SAP: fix "declaration of 'read' shadows a global" warning 77/3877/2
authorPaul Fertser <fercerpav@gmail.com>
Sun, 13 Nov 2016 12:02:55 +0000 (15:02 +0300)
committerPaul Fertser <fercerpav@gmail.com>
Thu, 8 Dec 2016 15:08:42 +0000 (15:08 +0000)
Change-Id: I7070193819cc134f9fe1427c20a11160ec415ccb
Reported-by: Jens Bauer <jens-lists@gpio.dk>
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/3877
Tested-by: jenkins
src/target/ls1_sap.c

index 944e7252043efa39f899eab05e25adad3ce89d0d..b4d814bbf5b36ff6cf62bab318f745978c95111a 100644 (file)
@@ -127,7 +127,7 @@ static void ls1_sap_set_addr_high(struct jtag_tap *tap, uint16_t addr_high)
 }
 
 static void ls1_sap_memory_cmd(struct jtag_tap *tap, uint32_t address,
-                              int32_t size, int read)
+                              int32_t size, bool rnw)
 {
        struct scan_field field;
        uint8_t cmd[8];
@@ -138,7 +138,7 @@ static void ls1_sap_memory_cmd(struct jtag_tap *tap, uint32_t address,
        field.out_value = cmd;
        buf_set_u64(cmd, 0, 9, 0);
        buf_set_u64(cmd, 9, 3, size);
-       buf_set_u64(cmd, 12, 1, !!read);
+       buf_set_u64(cmd, 12, 1, rnw);
        buf_set_u64(cmd, 13, 3, 0);
        buf_set_u64(cmd, 16, 32, address);
        buf_set_u64(cmd, 48, 16, 0);
@@ -190,7 +190,7 @@ static int ls1_sap_read_memory(struct target *target, uint32_t address,
        ls1_sap_set_addr_high(target->tap, 0);
 
        while (count--) {
-               ls1_sap_memory_cmd(target->tap, address, size, 1);
+               ls1_sap_memory_cmd(target->tap, address, size, true);
                ls1_sap_memory_read(target->tap, size, buffer);
                address += size;
                buffer += size;
@@ -213,7 +213,7 @@ static int ls1_sap_write_memory(struct target *target, uint32_t address,
        ls1_sap_set_addr_high(target->tap, 0);
 
        while (count--) {
-               ls1_sap_memory_cmd(target->tap, address, size, 0);
+               ls1_sap_memory_cmd(target->tap, address, size, false);
                ls1_sap_memory_write(target->tap, size, buffer);
                address += size;
                buffer += size;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)