Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: d491b88)
tcl: target: imx5{1,3}: remove bogus tapenable command 92/3892/2
authorPaul Fertser <fercerpav@gmail.com>
Wed, 30 Nov 2016 09:51:35 +0000 (12:51 +0300)
committerPaul Fertser <fercerpav@gmail.com>
Sun, 25 Dec 2016 09:44:01 +0000 (09:44 +0000)
This seems to be a leftover from borrowing from omap3* configs. Since
SJC is not enabling or disabling the DAP tap, and the tap is always
available, the extra tapenable command causes warnings on startup
(can't enable what's already enabled).

Change-Id: I7514436d565aa5b91876dbdab547956f36dcab77
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/3892
Tested-by: jenkins
tcl/target/imx51.cfg patch | blob | history
tcl/target/imx53.cfg patch | blob | history

diff --git a/tcl/target/imx51.cfg b/tcl/target/imx51.cfg
index b143aad2585c701e8a2f8468db49ebceab563932..d10cf9f5d5b2da3df6bb1ecd3f3fc484696a8a2d 100644 (file)
--- a/tcl/target/imx51.cfg
+++ b/tcl/target/imx51.cfg
@@ -36,9 +36,6 @@ target create $_TARGETNAME cortex_a -chain-position $_CHIPNAME.DAP
 # some TCK tycles are required to activate the DEBUG power domain
 jtag configure $_CHIPNAME.SJC -event post-reset "runtest 100"
 
-# have the DAP "always" be active
-jtag configure $_CHIPNAME.SJC -event setup "jtag tapenable $_CHIPNAME.DAP"
-
 proc imx51_dbginit {target} {
      # General Cortex-A8 debug initialisation
      cortex_a dbginit
diff --git a/tcl/target/imx53.cfg b/tcl/target/imx53.cfg
index 87a3008e4de0c5bd94a45c9f276177361fcc16d5..5ad6473a8ef890fc44107bf9b13575d404e3b359 100644 (file)
--- a/tcl/target/imx53.cfg
+++ b/tcl/target/imx53.cfg
@@ -36,9 +36,6 @@ target create $_TARGETNAME cortex_a -chain-position $_CHIPNAME.DAP
 # some TCK tycles are required to activate the DEBUG power domain
 jtag configure $_CHIPNAME.SJC -event post-reset "runtest 100"
 
-# have the DAP "always" be active
-jtag configure $_CHIPNAME.SJC -event setup "jtag tapenable $_CHIPNAME.DAP"
-
 proc imx53_dbginit {target} {
      # General Cortex-A8 debug initialisation
      cortex_a dbginit
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)