helper: util: rewrite command 'ms' as COMMAND_HANDLER 87/7487/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Sun, 18 Dec 2022 17:49:02 +0000 (18:49 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 25 Mar 2023 18:10:14 +0000 (18:10 +0000)
Use full 64 bits in output; no reason to truncate at 32 bits.

Change-Id: I433815a381e147731ff0da2c805170649a9bcf38
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7487
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
src/helper/util.c

index bf18f8e6035f60a0c716a729f3a2e296c1b40e9e..5e12021ff5368334393117c242295d66f6740326 100644 (file)
 #include "log.h"
 #include "time_support.h"
 
-static int jim_util_ms(Jim_Interp *interp,
-       int argc,
-       Jim_Obj * const *argv)
+COMMAND_HANDLER(handler_util_ms)
 {
-       if (argc != 1) {
-               Jim_WrongNumArgs(interp, 1, argv, "ls ?dir?");
-               return JIM_ERR;
-       }
+       if (CMD_ARGC != 0)
+               return ERROR_COMMAND_SYNTAX_ERROR;
 
-       /* Cast from 64 to 32 bit int works for 2's-compliment
-        * when calculating differences*/
-       Jim_SetResult(interp, Jim_NewIntObj(interp, (int)timeval_ms()));
+       command_print(CMD, "%" PRId64, timeval_ms());
 
-       return JIM_OK;
+       return ERROR_OK;
 }
 
 static const struct command_registration util_command_handlers[] = {
-       /* jim handlers */
        {
                .name = "ms",
                .mode = COMMAND_ANY,
-               .jim_handler = jim_util_ms,
+               .handler = handler_util_ms,
                .help =
                        "Returns ever increasing milliseconds. Used to calculate differences in time.",
                .usage = "",

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)