add src/hello.c to augment new command tutorial
authorZachary T Welch <zw@superlucidity.net>
Wed, 11 Nov 2009 09:20:49 +0000 (01:20 -0800)
committerZachary T Welch <zw@superlucidity.net>
Fri, 13 Nov 2009 18:57:57 +0000 (10:57 -0800)
The hello module provides the 'hello' command, printing a greetings
to the command console.  It can grow to serve as pedagogical example
of services that OpenOCD developers should use: a runnable style guide.

src/Makefile.am
src/hello.c [new file with mode: 0644]
src/openocd.c

index 67179107c98fcfe7d759c39f8b5ee0339fac7f18..7721f34010ffe200ae382053382b0fac3c50eb80 100644 (file)
@@ -12,7 +12,9 @@ endif
 openocd_SOURCES = $(MAINFILE)
 openocd_LDADD = libopenocd.la
 
 openocd_SOURCES = $(MAINFILE)
 openocd_LDADD = libopenocd.la
 
-libopenocd_la_SOURCES = openocd.c
+libopenocd_la_SOURCES = \
+       hello.c \
+       openocd.c
 
 # set the include path found by configure
 AM_CPPFLAGS = \
 
 # set the include path found by configure
 AM_CPPFLAGS = \
diff --git a/src/hello.c b/src/hello.c
new file mode 100644 (file)
index 0000000..8a4f701
--- /dev/null
@@ -0,0 +1,57 @@
+/***************************************************************************
+ *   Copyright (C) 2009 Zachary T Welch <zw@superlucidity.net>             *
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ *   This program is distributed in the hope that it will be useful,       *
+ *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
+ *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
+ *   GNU General Public License for more details.                          *
+ *                                                                         *
+ *   You should have received a copy of the GNU General Public License     *
+ *   along with this program; if not, write to the                         *
+ *   Free Software Foundation, Inc.,                                       *
+ *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ ***************************************************************************/
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+#include "log.h"
+
+static COMMAND_HELPER(handle_hello_args, const char **sep, const char **name)
+{
+       if (argc > 1)
+       {
+               LOG_ERROR("%s: too many arguments", CMD_NAME);
+               return ERROR_COMMAND_SYNTAX_ERROR;
+       }
+       if (1 == argc)
+       {
+               *sep = " ";
+               *name = args[0];
+       }
+       else
+               *sep = *name = "";
+
+       return ERROR_OK;
+}
+COMMAND_HANDLER(handle_hello_command)
+{
+       const char *sep, *name;
+       int retval = CALL_COMMAND_HANDLER(handle_hello_args, &sep, &name);
+       if (ERROR_OK == retval)
+               command_print(cmd_ctx, "Greetings%s%s!", sep, name);
+       return retval;
+}
+
+int hello_register_commands(struct command_context_s *cmd_ctx)
+{
+       struct command_s *cmd = register_command(cmd_ctx, NULL, "hello",
+                       &handle_hello_command, COMMAND_ANY,
+                       "option");
+       return cmd ? ERROR_OK : -ENOMEM;
+}
index 2a74a46b741b0c2ad762f175d47371f2336a5024..d67ebd59b176273a1be992ef3b6e3a38da08120e 100644 (file)
@@ -177,6 +177,9 @@ COMMAND_HANDLER(handle_init_command)
 
 command_context_t *global_cmd_ctx;
 
 
 command_context_t *global_cmd_ctx;
 
+/// src/hello.c gives a simple example for writing new command modules
+int hello_register_commands(struct command_context_s *cmd_ctx);
+
 /* NB! this fn can be invoked outside this file for non PC hosted builds */
 command_context_t *setup_command_handler(void)
 {
 /* NB! this fn can be invoked outside this file for non PC hosted builds */
 command_context_t *setup_command_handler(void)
 {
@@ -188,6 +191,7 @@ command_context_t *setup_command_handler(void)
                                         COMMAND_EXEC, "show OpenOCD version");
 
        /* register subsystem commands */
                                         COMMAND_EXEC, "show OpenOCD version");
 
        /* register subsystem commands */
+       hello_register_commands(cmd_ctx);
        server_register_commands(cmd_ctx);
        telnet_register_commands(cmd_ctx);
        gdb_register_commands(cmd_ctx);
        server_register_commands(cmd_ctx);
        telnet_register_commands(cmd_ctx);
        gdb_register_commands(cmd_ctx);

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)