aarch64: remove bogus address check before memory access 87/3987/3
authorMatthias Welwarsky <matthias.welwarsky@sysgo.com>
Sun, 27 Nov 2016 10:28:01 +0000 (11:28 +0100)
committerPaul Fertser <fercerpav@gmail.com>
Fri, 24 Feb 2017 09:14:32 +0000 (09:14 +0000)
Mmu faults can not be prevented on aarch64, they need to be taken and
handled accordingly. Remove the remaining stub code.

Change-Id: I6241efa594fe6b963624f9628cdf1c8e46588223
Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com>
Reviewed-on: http://openocd.zylin.com/3987
Tested-by: jenkins
Reviewed-by: Paul Fertser <fercerpav@gmail.com>
src/target/aarch64.c

index d3ed57c5d8a38015cc3792517bc09821ee5ab8e3..5dd6d7adea66d196af13f6d1612374bf2abd5b45 100644 (file)
@@ -103,13 +103,6 @@ static int aarch64_restore_system_control_reg(struct target *target)
        return retval;
 }
 
-/*  check address before aarch64_apb read write access with mmu on
- *  remove apb predictible data abort */
-static int aarch64_check_address(struct target *target, uint32_t address)
-{
-       /* TODO */
-       return ERROR_OK;
-}
 /*  modify system_control_reg in order to enable or disable mmu for :
  *  - virt2phys address conversion
  *  - read or write memory in phys or virt address */
@@ -1651,9 +1644,6 @@ static int aarch64_read_memory(struct target *target, target_addr_t address,
                return retval;
 
        if (mmu_enabled) {
-               retval = aarch64_check_address(target, address);
-               if (retval != ERROR_OK)
-                       return retval;
                /* enable MMU as we could have disabled it for phys access */
                retval = aarch64_mmu_modify(target, 1);
                if (retval != ERROR_OK)
@@ -1691,9 +1681,6 @@ static int aarch64_write_memory(struct target *target, target_addr_t address,
                return retval;
 
        if (mmu_enabled) {
-               retval = aarch64_check_address(target, address);
-               if (retval != ERROR_OK)
-                       return retval;
                /* enable MMU as we could have disabled it for phys access */
                retval = aarch64_mmu_modify(target, 1);
                if (retval != ERROR_OK)

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)