fix segfault at startup
authorZachary T Welch <zw@superlucidity.net>
Wed, 18 Nov 2009 19:56:24 +0000 (11:56 -0800)
committerZachary T Welch <zw@superlucidity.net>
Wed, 18 Nov 2009 19:56:24 +0000 (11:56 -0800)
The previous changes to move the startup TCL code resulted in segfaults
during startup.  This seemingly innocuous patch fixes the problem.
I would explain why changing from 'foo[]' to '*foo' caused this issue,
but the difference seems superficial.  For now, this hot fix will do,
but this issue might bear further scrutiny.

src/openocd.h

index 70e3ee0126f30e524bc1c935b3b4ac3af0ee0a08..a91d46f2f2568358f0ec402fc2366117fc04abcc 100644 (file)
@@ -37,6 +37,6 @@ void openocd_sleep_prelude(void);
 void openocd_sleep_postlude(void);
 
 /// provides a hard-coded command environment setup
 void openocd_sleep_postlude(void);
 
 /// provides a hard-coded command environment setup
-extern const char *openocd_startup_tcl;
+extern const char openocd_startup_tcl[];
 
 #endif
 
 #endif

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)