stlink: use common layout 18/918/5
authorSpencer Oliver <spen@spen-soft.co.uk>
Mon, 15 Oct 2012 11:34:46 +0000 (12:34 +0100)
committerSpencer Oliver <spen@spen-soft.co.uk>
Sun, 23 Dec 2012 21:37:50 +0000 (21:37 +0000)
Even though the stlinkv1 and stlinkv2 use different usb classes they share
the same layout scheme.

Merge the two into a common layout, thus enabling us to support other
adapter layouts.

Change-Id: I7d02c44a7f94ebc7f2cb5428b02ee40294fb430d
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/918
Tested-by: jenkins
src/jtag/stlink/stlink_layout.c
src/jtag/stlink/stlink_layout.h
tcl/interface/stlink-v1.cfg
tcl/interface/stlink-v2.cfg

index 4ef9b765f159054534cb6eca79e33497d6c24db2..cd0ba7f571960945d067e1b907c68364d60bf632 100644 (file)
 #include <jtag/stlink/stlink_transport.h>
 #include <jtag/stlink/stlink_interface.h>
 
-#define STLINK_LAYOUT_UNKNOWN  0
-#define STLINK_LAYOUT_SG       1
-#define STLINK_LAYOUT_USB      2
-
 static int stlink_layout_open(struct stlink_interface_s *stlink_if)
 {
        int res;
@@ -61,15 +57,7 @@ static int stlink_layout_close(struct stlink_interface_s *stlink_if)
 
 static const struct stlink_layout stlink_layouts[] = {
        {
-        .name = "usb",
-        .type = STLINK_LAYOUT_USB,
-        .open = stlink_layout_open,
-        .close = stlink_layout_close,
-        .api = &stlink_usb_layout_api,
-        },
-       {
-        .name = "sg",
-        .type = STLINK_LAYOUT_SG,
+        .name = "stlink",
         .open = stlink_layout_open,
         .close = stlink_layout_close,
         .api = &stlink_usb_layout_api,
index 905105a0a11a0b9b409487272f9368172cb7f7bc..8d2a98ac169c97da05e880c36c3fb21fc04ccd97 100644 (file)
@@ -75,8 +75,6 @@ struct stlink_layout {
        /** */
        char *name;
        /** */
-       int type;
-       /** */
        int (*open) (struct stlink_interface_s *stlink_if);
        /** */
        int (*close) (struct stlink_interface_s *stlink_if);
index af678187e1b54ef10a9e9eea870b960470362bcd..00031837159a882f03b1ced22462a6d6b2128e50 100644 (file)
@@ -3,7 +3,7 @@
 #
 
 interface stlink
-stlink_layout sg
+stlink_layout stlink
 stlink_device_desc "ST-LINK/V1"
 stlink_vid_pid 0x0483 0x3744
 
index 3eee7d9e9c09011d0a1dc6cb49e30e88d0f8777c..25e696c6a926fc9d8085a0a0c543f4111645382f 100644 (file)
@@ -3,7 +3,7 @@
 #
 
 interface stlink
-stlink_layout usb
+stlink_layout stlink
 stlink_device_desc "ST-LINK/V2"
 stlink_vid_pid 0x0483 0x3748
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)