openrisc: Fix segv jsp due to free of unallocated data

The prompt pointer in the jtag serial port is never zero'd or allocated.
Completely remove it since there is not much use for it as the target
software will provide the actual prompt.

Change-Id: Id95d8ccb9f725e53b9d03386b11d91eba1cd6ef4
Signed-off-by: Stafford Horne <shorne@gmail.com>
Reviewed-on: http://openocd.zylin.com/4093
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

diff --git a/src/target/openrisc/jsp_server.c b/src/target/openrisc/jsp_server.c
index 6fb764a6c658d1dbfc14698f034d39a1c14591a0..f28815df9fc0af33a9ff0f72e99ba1362770b103 100644 (file)
--- a/src/target/openrisc/jsp_server.c
+++ b/src/target/openrisc/jsp_server.c
@@ -184,14 +184,8 @@ static int jsp_input(struct connection *connection)
 
 static int jsp_connection_closed(struct connection *connection)
 {
-       struct telnet_connection *t_con = connection->priv;
        struct jsp_service *jsp_service = connection->service->priv;
 
-       if (t_con->prompt) {
-               free(t_con->prompt);
-               t_con->prompt = NULL;
-       }
-
        int retval = target_unregister_timer_callback(&jsp_poll_read, jsp_service);
        if (ERROR_OK != retval)
                return retval;