target/openrisc: use coherent syntax in struct initialization 12/5012/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Fri, 4 Jan 2019 10:36:39 +0000 (11:36 +0100)
committerTomas Vanek <vanekt@fbl.cz>
Sun, 7 Apr 2019 07:14:44 +0000 (08:14 +0100)
While initializing struct command_registration, the field's name "name"
is not specified, thus relying on the fact that it is the first field
declared in the struct and it's initialization value can be listed as
the first one.

Be coherent in the struct initialization and always use the field's
name.

Change-Id: I65d32870bf4d3df845db69682fe445c71642f976
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5012
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
src/target/openrisc/or1k.c

index 34b1b07483bcacd3d469b137d7ae084ffcc63866..1cecebd306061b4908d353f6499bcb11c29237e8 100644 (file)
@@ -1374,28 +1374,28 @@ COMMAND_HANDLER(or1k_addreg_command_handler)
 
 static const struct command_registration or1k_hw_ip_command_handlers[] = {
        {
 
 static const struct command_registration or1k_hw_ip_command_handlers[] = {
        {
-               "tap_select",
+               .name = "tap_select",
                .handler = or1k_tap_select_command_handler,
                .mode = COMMAND_ANY,
                .usage = "tap_select name",
                .help = "Select the TAP core to use",
        },
        {
                .handler = or1k_tap_select_command_handler,
                .mode = COMMAND_ANY,
                .usage = "tap_select name",
                .help = "Select the TAP core to use",
        },
        {
-               "tap_list",
+               .name = "tap_list",
                .handler = or1k_tap_list_command_handler,
                .mode = COMMAND_ANY,
                .usage = "tap_list",
                .help = "Display available TAP core",
        },
        {
                .handler = or1k_tap_list_command_handler,
                .mode = COMMAND_ANY,
                .usage = "tap_list",
                .help = "Display available TAP core",
        },
        {
-               "du_select",
+               .name = "du_select",
                .handler = or1k_du_select_command_handler,
                .mode = COMMAND_ANY,
                .usage = "du_select name",
                .help = "Select the Debug Unit core to use",
        },
        {
                .handler = or1k_du_select_command_handler,
                .mode = COMMAND_ANY,
                .usage = "du_select name",
                .help = "Select the Debug Unit core to use",
        },
        {
-               "du_list",
+               .name = "du_list",
                .handler = or1k_du_list_command_handler,
                .mode = COMMAND_ANY,
                .usage = "select_tap name",
                .handler = or1k_du_list_command_handler,
                .mode = COMMAND_ANY,
                .usage = "select_tap name",
@@ -1406,7 +1406,7 @@ static const struct command_registration or1k_hw_ip_command_handlers[] = {
 
 static const struct command_registration or1k_reg_command_handlers[] = {
        {
 
 static const struct command_registration or1k_reg_command_handlers[] = {
        {
-               "addreg",
+               .name = "addreg",
                .handler = or1k_addreg_command_handler,
                .mode = COMMAND_ANY,
                .usage = "addreg name addr feature group",
                .handler = or1k_addreg_command_handler,
                .mode = COMMAND_ANY,
                .usage = "addreg name addr feature group",

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)