flash: with pointers, use NULL instead of 0

Don't compare pointers with 0, use NULL when needed.
Don't pass 0 ad pointer argument, pass NULL.

Detected through 'sparse' tool.

Change-Id: I118554fffde41c94cea9e1201ea941ff3c1ee762
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7595
Tested-by: jenkins

diff --git a/src/flash/nand/lpc32xx.c b/src/flash/nand/lpc32xx.c
index 2c578d1b425d5e73afae35c7c81549dc317c596d..f8b59b357a936061d24a4dfcbb47bddfd4c27d08 100644 (file)
--- a/src/flash/nand/lpc32xx.c
+++ b/src/flash/nand/lpc32xx.c
@@ -1029,7 +1029,7 @@ static int lpc32xx_write_page_slc(struct nand_device *nand,
 
        LOG_DEBUG("SLC write page %" PRIx32 " data=%d, oob=%d, "
                "data_size=%" PRIu32 ", oob_size=%" PRIu32,
-               page, data != 0, oob != 0, data_size, oob_size);
+               page, !!data, !!oob, data_size, oob_size);
 
        target_mem_base = pworking_area->address;
        /*

diff --git a/src/flash/nor/msp432.c b/src/flash/nor/msp432.c
index d9b9695dfef41a4e992fab292b3207a15d09d21e..5e2935d02bf41d510847f5159ef8f528df16c615 100644 (file)
--- a/src/flash/nor/msp432.c
+++ b/src/flash/nor/msp432.c
@@ -375,7 +375,7 @@ static int msp432_init(struct flash_bank *bank)
        buf_set_u32(reg_params[0].value, 0, 32, ALGO_STACK_POINTER_ADDR);
 
        /* Begin executing the flash helper algorithm */
-       retval = target_start_algorithm(target, 0, 0, 1, reg_params,
+       retval = target_start_algorithm(target, 0, NULL, 1, reg_params,
                                algo_entry_addr, 0, &msp432_bank->armv7m_info);
        destroy_reg_param(&reg_params[0]);
        if (retval != ERROR_OK) {

diff --git a/src/flash/nor/stellaris.c b/src/flash/nor/stellaris.c
index 3a78952efda8c102c4a7d18d4b484e7c15d58ba5..972686e3f3c4e8eddd9533a782eed2d8753e6299 100644 (file)
--- a/src/flash/nor/stellaris.c
+++ b/src/flash/nor/stellaris.c
@@ -1342,7 +1342,7 @@ COMMAND_HANDLER(stellaris_handle_recover_command)
         * cycle to recover.
         */
 
-       Jim_Eval_Named(CMD_CTX->interp, "catch { hla_command \"debug unlock\" }", 0, 0);
+       Jim_Eval_Named(CMD_CTX->interp, "catch { hla_command \"debug unlock\" }", NULL, 0);
        if (!strcmp(Jim_GetString(Jim_GetResult(CMD_CTX->interp), NULL), "0")) {
                retval = ERROR_OK;
                goto user_action;