target/arm720t: remove command 'arm720t cp15' deprecated in v0.4.0

The command 'arm720t cp15' was marked as deprecated in release
v0.4.0, almost 11 years ago.
We can reasonably expect that in these years any user of OpenOCD
has already migrated to v0.4.0 or to some newer release, thus has
already updated any local/personal script.
There is no run-time warning about the deprecation, but it is
reported in the help and in the documentation.

Drop the command already deprecated in v0.4.0.

Change-Id: I2b325d0312d96ca5e5f0f1bad13bb162b3b75c52
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6082
Tested-by: jenkins
Reviewed-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>

diff --git a/doc/openocd.texi b/doc/openocd.texi
index 0c1714e49468c9246b24732b0df4a1ae90df93fe..934c37e5dabad739f0e2b3ef37447198a3077194 100644 (file)
--- a/doc/openocd.texi
+++ b/doc/openocd.texi
@@ -9114,23 +9114,6 @@ cables (FT2232), but might be unsafe if used with targets running at very low
 speeds, like the 32kHz startup clock of an AT91RM9200.
 @end deffn
 
-@subsection ARM720T specific commands
-@cindex ARM720T
-
-These commands are available to ARM720T based CPUs,
-which are implementations of the ARMv4T architecture
-based on the ARM7TDMI-S integer core.
-They are available in addition to the ARM and ARM7/ARM9 commands.
-
-@deffn Command {arm720t cp15} opcode [value]
-@emph{DEPRECATED -- avoid using this.
-Use the @command{arm mrc} or @command{arm mcr} commands instead.}
-
-Display cp15 register returned by the ARM instruction @var{opcode};
-else if a @var{value} is provided, that value is written to that register.
-The @var{opcode} should be the value of either an MRC or MCR instruction.
-@end deffn
-
 @subsection ARM9 specific commands
 @cindex ARM9
 

diff --git a/src/target/arm720t.c b/src/target/arm720t.c
index e04cab2e7972ba24aa54d8137061b707fe7e7ce4..daa44e46aa125ed284c7de713fa5e2a23152fb34 100644 (file)
--- a/src/target/arm720t.c
+++ b/src/target/arm720t.c
@@ -233,16 +233,6 @@ static void arm720t_pre_restore_context(struct target *target)
        arm720t_write_cp15(target, 0xee060f10, arm720t->far_reg);
 }
 
-static int arm720t_verify_pointer(struct command_invocation *cmd,
-               struct arm720t_common *arm720t)
-{
-       if (arm720t->common_magic != ARM720T_COMMON_MAGIC) {
-               command_print(cmd, "target is not an ARM720");
-               return ERROR_TARGET_INVALID;
-       }
-       return ERROR_OK;
-}
-
 static int arm720t_arch_state(struct target *target)
 {
        struct arm720t_common *arm720t = target_to_arm720(target);
@@ -441,55 +431,6 @@ static int arm720t_target_create(struct target *target, Jim_Interp *interp)
        return arm720t_init_arch_info(target, arm720t, target->tap);
 }
 
-COMMAND_HANDLER(arm720t_handle_cp15_command)
-{
-       int retval;
-       struct target *target = get_current_target(CMD_CTX);
-       struct arm720t_common *arm720t = target_to_arm720(target);
-
-       retval = arm720t_verify_pointer(CMD, arm720t);
-       if (retval != ERROR_OK)
-               return retval;
-
-       if (target->state != TARGET_HALTED) {
-               command_print(CMD, "target must be stopped for \"%s\" command", CMD_NAME);
-               return ERROR_OK;
-       }
-
-       /* one or more argument, access a single register (write if second argument is given */
-       if (CMD_ARGC >= 1) {
-               uint32_t opcode;
-               COMMAND_PARSE_NUMBER(u32, CMD_ARGV[0], opcode);
-
-               if (CMD_ARGC == 1) {
-                       uint32_t value;
-                       retval = arm720t_read_cp15(target, opcode, &value);
-                       if (retval != ERROR_OK) {
-                               command_print(CMD, "couldn't access cp15 with opcode 0x%8.8" PRIx32 "", opcode);
-                               return ERROR_OK;
-                       }
-
-                       retval = jtag_execute_queue();
-                       if (retval != ERROR_OK)
-                               return retval;
-
-                       command_print(CMD, "0x%8.8" PRIx32 ": 0x%8.8" PRIx32 "", opcode, value);
-               } else if (CMD_ARGC == 2) {
-                       uint32_t value;
-                       COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], value);
-
-                       retval = arm720t_write_cp15(target, opcode, value);
-                       if (retval != ERROR_OK) {
-                               command_print(CMD, "couldn't access cp15 with opcode 0x%8.8" PRIx32 "", opcode);
-                               return ERROR_OK;
-                       }
-                       command_print(CMD, "0x%8.8" PRIx32 ": 0x%8.8" PRIx32 "", opcode, value);
-               }
-       }
-
-       return ERROR_OK;
-}
-
 static int arm720t_mrc(struct target *target, int cpnum,
                uint32_t op1, uint32_t op2,
                uint32_t CRn, uint32_t CRm,
@@ -523,30 +464,10 @@ static int arm720t_mcr(struct target *target, int cpnum,
                        value);
 }
 
-static const struct command_registration arm720t_exec_command_handlers[] = {
-       {
-               .name = "cp15",
-               .handler = arm720t_handle_cp15_command,
-               .mode = COMMAND_EXEC,
-               /* prefer using less error-prone "arm mcr" or "arm mrc" */
-               .help = "display/modify cp15 register using ARM opcode"
-                       " (DEPRECATED)",
-               .usage = "instruction [value]",
-       },
-       COMMAND_REGISTRATION_DONE
-};
-
 static const struct command_registration arm720t_command_handlers[] = {
        {
                .chain = arm7_9_command_handlers,
        },
-       {
-               .name = "arm720t",
-               .mode = COMMAND_ANY,
-               .help = "arm720t command group",
-               .usage = "",
-               .chain = arm720t_exec_command_handlers,
-       },
        COMMAND_REGISTRATION_DONE
 };