Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: fe2fd81)
config files: Drop incorrect comments.
authorUwe Hermann <uwe@hermann-uwe.de>
Sat, 29 Oct 2011 20:58:12 +0000 (22:58 +0200)
committerPeter Stuge <peter@stuge.se>
Sun, 30 Oct 2011 01:57:33 +0000 (01:57 +0000)
There are many "force an error till we get a good number" comments in
target/board files. This refers to the use-case where a config script
sets _CPUTAPID to 0xffffffff (which presumely gets overridden later):

 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
    # Force an error until we get a good number.
    set _CPUTAPID 0xffffffff
 }

However, the same comment was also copy-pasted in many files which do
_not_ set _CPUTAPID to 0xffffffff, where the comment doesn't make any
sense at all. Drop those comments. Also, add one missing comment, and
fix small whitespace and grammar issues.

Change-Id: Ic4ba3b5ccba87ed40cea0d6a7d66609fbdfa3c71
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Reviewed-on: http://openocd.zylin.com/136
Tested-by: jenkins
Reviewed-by: Peter Stuge <peter@stuge.se>
18 files changed:
tcl/board/at91eb40a.cfg patch | blob | history
tcl/board/mini2440.cfg patch | blob | history
tcl/target/at91sam7se512.cfg patch | blob | history
tcl/target/at91sam9.cfg patch | blob | history
tcl/target/avr32.cfg patch | blob | history
tcl/target/dsp56321.cfg patch | blob | history
tcl/target/dsp568013.cfg patch | blob | history
tcl/target/dsp568037.cfg patch | blob | history
tcl/target/epc9301.cfg patch | blob | history
tcl/target/is5114.cfg patch | blob | history
tcl/target/pic32mx.cfg patch | blob | history
tcl/target/samsung_s3c2410.cfg patch | blob | history
tcl/target/samsung_s3c2440.cfg patch | blob | history
tcl/target/samsung_s3c2450.cfg patch | blob | history
tcl/target/samsung_s3c6410.cfg patch | blob | history
tcl/target/smp8634.cfg patch | blob | history
tcl/target/tmpa900.cfg patch | blob | history
tcl/target/tmpa910.cfg patch | blob | history

diff --git a/tcl/board/at91eb40a.cfg b/tcl/board/at91eb40a.cfg
index dc5aacbf05fd1bc871aec7d25400bcb67d8415fc..b43dee3d810dc6604f120a4b0e7813f255cb8b55 100644 (file)
--- a/tcl/board/at91eb40a.cfg
+++ b/tcl/board/at91eb40a.cfg
@@ -19,7 +19,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x1f0f0f0f
 }
 
diff --git a/tcl/board/mini2440.cfg b/tcl/board/mini2440.cfg
index c5adac360fc6e37a899385b98cb54c7147218fa1..a0345387dc8603805c90785c1e0dcd38625263d3 100644 (file)
--- a/tcl/board/mini2440.cfg
+++ b/tcl/board/mini2440.cfg
@@ -100,7 +100,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x0032409d
 }
 
diff --git a/tcl/target/at91sam7se512.cfg b/tcl/target/at91sam7se512.cfg
index c48afeffd54027f67b796e96da2612fb35f2b65f..7273a069bc26c49e1392756b983404a89cc7dc58 100644 (file)
--- a/tcl/target/at91sam7se512.cfg
+++ b/tcl/target/at91sam7se512.cfg
@@ -18,7 +18,7 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
+   # Force an error until we get a good number.
    set _CPUTAPID 0xffffffff
 }
 
diff --git a/tcl/target/at91sam9.cfg b/tcl/target/at91sam9.cfg
index ba0197d90b0cc42c2ca5f87dfdef7b04d6014a26..08154ceac77ea6ef077894c8a3c6bd83db4c4ed1 100644 (file)
--- a/tcl/target/at91sam9.cfg
+++ b/tcl/target/at91sam9.cfg
@@ -17,13 +17,11 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
        set _CPUTAPID $CPUTAPID
 } else {
-       # force an error till we get a good number
        set _CPUTAPID 0x0792603f
 }
 
 reset_config trst_and_srst separate trst_push_pull srst_open_drain
 
-#
 jtag newtap $_CHIPNAME cpu -irlen 4 -ircapture 0x1 -irmask 0xf -expected-id $_CPUTAPID
 
 adapter_nsrst_delay 300
diff --git a/tcl/target/avr32.cfg b/tcl/target/avr32.cfg
index 7fe98b2ce4dad3aa212072169097a6e878c2043c..1a2ea330ac6fffec33d384910bc84112071750a8 100644 (file)
--- a/tcl/target/avr32.cfg
+++ b/tcl/target/avr32.cfg
@@ -1,7 +1,6 @@
 set  _CHIPNAME avr32
 set  _ENDIAN big
 
-# force an error till we get a good number
 set _CPUTAPID  0x21e8203f
 
 jtag_nsrst_delay 100
diff --git a/tcl/target/dsp56321.cfg b/tcl/target/dsp56321.cfg
index 281c4ddd47215faa486d7fcc01f08d8feade29f5..74279d997bb887e8b1facf639c35b01f884c4180 100644 (file)
--- a/tcl/target/dsp56321.cfg
+++ b/tcl/target/dsp56321.cfg
@@ -17,7 +17,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x1181501d
 }
 
diff --git a/tcl/target/dsp568013.cfg b/tcl/target/dsp568013.cfg
index 80adc7639445cac243331a1000e59df23a9205e2..2b25ed7e3b06b91c39e42f332accc2f169bc5f21 100644 (file)
--- a/tcl/target/dsp568013.cfg
+++ b/tcl/target/dsp568013.cfg
@@ -16,7 +16,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x01f2401d
 }
 
diff --git a/tcl/target/dsp568037.cfg b/tcl/target/dsp568037.cfg
index 6089e9d242a49bf517234ccc21c01078ec532ffc..21eb0b70441ad0d77ffa8dbd93de09479fd3dafd 100644 (file)
--- a/tcl/target/dsp568037.cfg
+++ b/tcl/target/dsp568037.cfg
@@ -16,7 +16,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x01f2801d
 }
 
diff --git a/tcl/target/epc9301.cfg b/tcl/target/epc9301.cfg
index d2dc7ecb49efff8a7a166732e59d8fe774246c9a..6b67b9dcabf58f062ffa75bdbc4ced638199362f 100644 (file)
--- a/tcl/target/epc9301.cfg
+++ b/tcl/target/epc9301.cfg
@@ -15,7 +15,7 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
+   # Force an error until we get a good number.
    set _CPUTAPID 0xffffffff
 }
 
diff --git a/tcl/target/is5114.cfg b/tcl/target/is5114.cfg
index 64c0c8ef63f0046852f52644c77c2a6f57dfd591..56b9b65249a3cd8691a3dd8934e96cfc4dd7dca1 100644 (file)
--- a/tcl/target/is5114.cfg
+++ b/tcl/target/is5114.cfg
@@ -18,7 +18,7 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
+   # Force an error until we get a good number.
    set _CPUTAPID 0xffffffff
 }
 
diff --git a/tcl/target/pic32mx.cfg b/tcl/target/pic32mx.cfg
index efffd040b048bfc9b5d387b966832f623477390f..0b3522ee4c1219aa79aa99a091023ad121a4a0c7 100644 (file)
--- a/tcl/target/pic32mx.cfg
+++ b/tcl/target/pic32mx.cfg
@@ -14,7 +14,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-   # force an error till we get a good number
    set _CPUTAPID 0x30938053
 }
 
diff --git a/tcl/target/samsung_s3c2410.cfg b/tcl/target/samsung_s3c2410.cfg
index 9682c4c1a5b5c10756a3d38e2d644b36477fb26b..73d3b50039182dbf1c71323febb3b9e897d45e3e 100644 (file)
--- a/tcl/target/samsung_s3c2410.cfg
+++ b/tcl/target/samsung_s3c2410.cfg
@@ -16,6 +16,7 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID] } {
    set  _CPUTAPID $CPUTAPID
 } else {
+   # Force an error until we get a good number.
    set  _CPUTAPID 0xffffffff
 }
 
diff --git a/tcl/target/samsung_s3c2440.cfg b/tcl/target/samsung_s3c2440.cfg
index d3b665ffed3927b4bea5f1687f5db0314c71e6b1..9cd27d1e887e8aba06e3f94a47bc45c687505aaa 100644 (file)
--- a/tcl/target/samsung_s3c2440.cfg
+++ b/tcl/target/samsung_s3c2440.cfg
@@ -19,7 +19,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x0032409d
 }
 
diff --git a/tcl/target/samsung_s3c2450.cfg b/tcl/target/samsung_s3c2450.cfg
index 00754260014702ba05875d25c9e741ef37d7ba82..164fe16993a6aaa46ebc624733cddb4b1672fba4 100644 (file)
--- a/tcl/target/samsung_s3c2450.cfg
+++ b/tcl/target/samsung_s3c2450.cfg
@@ -29,7 +29,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
   set _CPUTAPID $CPUTAPID
 } else {
- # force an error till we get a good number
   set _CPUTAPID 0x07926f0f
 }
 
diff --git a/tcl/target/samsung_s3c6410.cfg b/tcl/target/samsung_s3c6410.cfg
index f9738c237f270e87c52a23eb45fd0916a45cf398..eb95242850a4c72e2e1a8e237fd2cb47b09d2ad0 100644 (file)
--- a/tcl/target/samsung_s3c6410.cfg
+++ b/tcl/target/samsung_s3c6410.cfg
@@ -23,14 +23,12 @@ if { [info exists ENDIAN] } {
 if { [info exists ETBTAPID ] } {
    set _ETBTAPID $ETBTAPID
 } else {
-  # force an error till we get a good number
    set _ETBTAPID 0x2b900f0f
 }
 
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x07b76f0f
 }
 
diff --git a/tcl/target/smp8634.cfg b/tcl/target/smp8634.cfg
index 4f3959d56dbeb9372a41ad7a3fe1abd98f1070c0..dc9bf0bdc134b2578a9e998046fe6991ed6323b4 100644 (file)
--- a/tcl/target/smp8634.cfg
+++ b/tcl/target/smp8634.cfg
@@ -15,7 +15,6 @@ if { [info exists ENDIAN] } {
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-   # force an error till we get a good number
    set _CPUTAPID 0x08630001
 }
 
diff --git a/tcl/target/tmpa900.cfg b/tcl/target/tmpa900.cfg
index cfb445e63526cf1b0a49b24779d5d2d7810e44c4..dd5d177d5a8fa90034958b8a6d796b7a7e74c71a 100644 (file)
--- a/tcl/target/tmpa900.cfg
+++ b/tcl/target/tmpa900.cfg
@@ -14,7 +14,6 @@ set _ENDIAN little
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x07926031
 }
 
diff --git a/tcl/target/tmpa910.cfg b/tcl/target/tmpa910.cfg
index 4d4d3fc2189f7888ab46a33cd4dd2ebed70601e1..271ca57d62234ff2e358cca85a35023dc15528c2 100644 (file)
--- a/tcl/target/tmpa910.cfg
+++ b/tcl/target/tmpa910.cfg
@@ -14,7 +14,6 @@ set _ENDIAN little
 if { [info exists CPUTAPID ] } {
    set _CPUTAPID $CPUTAPID
 } else {
-  # force an error till we get a good number
    set _CPUTAPID 0x07926031
 }
 
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)