openocd: use single line for register_commands*() 16/6716/2
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 8 Nov 2021 23:04:52 +0000 (00:04 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Tue, 23 Nov 2021 11:03:38 +0000 (11:03 +0000)
Do not split in multiple lines the calls to register_commands*().
No change in code behaviour, just make it easy to grep in the code
and identify the commands that can be registered.
This would help detecting undocumented commands.

Change-Id: Id654e107cdabf7ee31fc3d227c1d2a59acc5669e
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/6716
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/flash/nand/tcl.c
src/flash/nor/tcl.c
src/jtag/adapter.c
src/jtag/aice/aice_transport.c
src/jtag/hla/hla_transport.c
src/pld/pld.c
src/target/etm.c

index 6707314ccc824d3c87caebf02107c8b663aaa57c..b796fb7cec23cd66968af3379439d47989f2f283 100644 (file)
@@ -528,8 +528,7 @@ static COMMAND_HELPER(create_nand_device, const char *bank_name,
        }
 
        if (controller->commands) {
-               retval = register_commands(CMD_CTX, NULL,
-                               controller->commands);
+               retval = register_commands(CMD_CTX, NULL, controller->commands);
                if (retval != ERROR_OK)
                        return retval;
        }
index 228e76fd0f8688b79eece6c0a4231ce602a7c06d..b24191348d290818e756f5837633970cf67f44aa 100644 (file)
@@ -1284,8 +1284,7 @@ COMMAND_HANDLER(handle_flash_bank_command)
 
        /* register flash specific commands */
        if (driver->commands) {
-               int retval = register_commands(CMD_CTX, NULL,
-                               driver->commands);
+               int retval = register_commands(CMD_CTX, NULL, driver->commands);
                if (retval != ERROR_OK) {
                        LOG_ERROR("couldn't register '%s' commands",
                                driver_name);
index c30019c17539c4584493af125c486265841d2864..65874590dd9674f072571830e657435e6509ba4b 100644 (file)
@@ -367,8 +367,7 @@ COMMAND_HANDLER(handle_adapter_driver_command)
                        continue;
 
                if (adapter_drivers[i]->commands) {
-                       retval = register_commands(CMD_CTX, NULL,
-                                       adapter_drivers[i]->commands);
+                       retval = register_commands(CMD_CTX, NULL, adapter_drivers[i]->commands);
                        if (retval != ERROR_OK)
                                return retval;
                }
index 3e9d94219754e06f4c91937d3a75f90b8773bd66..c0088f5a4d6933487cf9b9ad82644a91aabc7245 100644 (file)
@@ -387,8 +387,7 @@ static const struct command_registration aice_transport_command_handlers[] = {
 /* */
 static int aice_transport_register_commands(struct command_context *cmd_ctx)
 {
-       return register_commands(cmd_ctx, NULL,
-                       aice_transport_command_handlers);
+       return register_commands(cmd_ctx, NULL, aice_transport_command_handlers);
 }
 
 /* */
index d925b174a8bd051526880e8c70ae0965ee60c879..684a52cb925d56c7ecfde6f29c6d2671d1514649 100644 (file)
@@ -196,15 +196,13 @@ static int hl_jtag_transport_select(struct command_context *cmd_ctx)
         * That works with only C code ... no Tcl glue required.
         */
 
-       return register_commands(cmd_ctx, NULL,
-                               hl_jtag_transport_command_handlers);
+       return register_commands(cmd_ctx, NULL, hl_jtag_transport_command_handlers);
 }
 
 static int hl_swd_transport_select(struct command_context *cmd_ctx)
 {
        LOG_DEBUG("hl_swd_transport_select");
-       return register_commands(cmd_ctx, NULL,
-                               hl_swd_transport_command_handlers);
+       return register_commands(cmd_ctx, NULL, hl_swd_transport_command_handlers);
 }
 
 static struct transport hl_swd_transport = {
index d0f85d74bffad1f699022a4f342f3ed318a91a1f..fe21f6c85b816a9cb274c2405356b55af0beb1c7 100644 (file)
@@ -67,8 +67,7 @@ COMMAND_HANDLER(handle_pld_device_command)
                        /* register pld specific commands */
                        int retval;
                        if (pld_drivers[i]->commands) {
-                               retval = register_commands(CMD_CTX, NULL,
-                                               pld_drivers[i]->commands);
+                               retval = register_commands(CMD_CTX, NULL, pld_drivers[i]->commands);
                                if (retval != ERROR_OK) {
                                        LOG_ERROR("couldn't register '%s' commands", CMD_ARGV[0]);
                                        return ERROR_FAIL;
index e8bd20fef41825e6fb544a509d600721b965ab4b..119c0df5d8c6c7777fbcbe96545837cc82e5f4e6 100644 (file)
@@ -1416,8 +1416,7 @@ COMMAND_HANDLER(handle_etm_config_command)
 
        for (i = 0; etm_capture_drivers[i]; i++) {
                if (strcmp(CMD_ARGV[4], etm_capture_drivers[i]->name) == 0) {
-                       int retval = register_commands(CMD_CTX, NULL,
-                                       etm_capture_drivers[i]->commands);
+                       int retval = register_commands(CMD_CTX, NULL, etm_capture_drivers[i]->commands);
                        if (retval != ERROR_OK) {
                                free(etm_ctx);
                                return retval;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)