Helper ioutil: cleanup: removing dead code 40/3240/3
authorAlexander Kurz <akurz@blala.de>
Sat, 13 Feb 2016 12:48:02 +0000 (13:48 +0100)
committerFreddie Chopin <freddie.chopin@gmail.com>
Sun, 8 May 2016 16:56:08 +0000 (17:56 +0100)
The ioutil helper functions copyfile and copydir were last and only used
in ecosboard.c which has been removed with commit 39650e22.
Removing the dead code.

Change-Id: I36c7c4c5009d755b4513a14a9f9e214d1ee500e8
Signed-off-by: Alexander Kurz <akurz@blala.de>
Reviewed-on: http://openocd.zylin.com/3240
Tested-by: jenkins
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
src/helper/ioutil.c

index 166256c7dc714dbf09c9a2faeeed70d7765189a7..e186724d59359470112df82a34612a5566d1c425 100644 (file)
@@ -243,117 +243,6 @@ COMMAND_HANDLER(handle_cp_command)
        return retval;
 }
 
-#define SHOW_RESULT(a, b) LOG_ERROR(# a " failed %d\n", (int)b)
-
-#define IOSIZE 512
-void copyfile(char *name2, char *name1)
-{
-
-       int err;
-       char buf[IOSIZE];
-       int fd1, fd2;
-       ssize_t done, wrote;
-
-       fd1 = open(name1, O_WRONLY | O_CREAT, 0664);
-       if (fd1 < 0)
-               SHOW_RESULT(open, fd1);
-
-       fd2 = open(name2, O_RDONLY);
-       if (fd2 < 0)
-               SHOW_RESULT(open, fd2);
-
-       for (;; ) {
-               done = read(fd2, buf, IOSIZE);
-               if (done < 0) {
-                       SHOW_RESULT(read, done);
-                       break;
-               }
-
-               if (done == 0)
-                       break;
-
-               wrote = write(fd1, buf, done);
-               if (wrote != done)
-                       SHOW_RESULT(write, wrote);
-
-               if (wrote != done)
-                       break;
-       }
-
-       err = close(fd1);
-       if (err < 0)
-               SHOW_RESULT(close, err);
-
-       err = close(fd2);
-       if (err < 0)
-               SHOW_RESULT(close, err);
-}
-
-/* utility fn to copy a directory */
-void copydir(char *name, char *destdir)
-{
-       int err;
-       DIR *dirp;
-
-       dirp = opendir(destdir);
-       if (dirp == NULL)
-               mkdir(destdir, 0777);
-       else
-               err = closedir(dirp);
-
-       dirp = opendir(name);
-       if (dirp == NULL)
-               SHOW_RESULT(opendir, -1);
-
-       for (;; ) {
-               struct dirent *entry = readdir(dirp);
-
-               if (entry == NULL)
-                       break;
-
-               if (strcmp(entry->d_name, ".") == 0)
-                       continue;
-               if (strcmp(entry->d_name, "..") == 0)
-                       continue;
-
-               int isDir = 0;
-               struct stat buf;
-               char fullPath[PATH_MAX];
-               strncpy(fullPath, name, PATH_MAX);
-               strcat(fullPath, "/");
-               strncat(fullPath, entry->d_name, PATH_MAX - strlen(fullPath));
-
-               if (stat(fullPath, &buf) == -1) {
-                       LOG_ERROR("unable to read status from %s", fullPath);
-                       break;
-               }
-               isDir = S_ISDIR(buf.st_mode) != 0;
-
-               if (isDir)
-                       continue;
-
-               /*        diag_printf("<INFO>: entry %14s",entry->d_name); */
-               char fullname[PATH_MAX];
-               char fullname2[PATH_MAX];
-
-               strcpy(fullname, name);
-               strcat(fullname, "/");
-               strcat(fullname, entry->d_name);
-
-               strcpy(fullname2, destdir);
-               strcat(fullname2, "/");
-               strcat(fullname2, entry->d_name);
-               /*        diag_printf("from %s to %s\n", fullname, fullname2); */
-               copyfile(fullname, fullname2);
-
-               /*       diag_printf("\n"); */
-       }
-
-       err = closedir(dirp);
-       if (err < 0)
-               SHOW_RESULT(stat, err);
-}
-
 COMMAND_HANDLER(handle_rm_command)
 {
        if (CMD_ARGC != 1)

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)