remove fast command and jim_global_long

Removing the fast command eliminates the fast_and_dangerous global,
which was used only by arm7_9_common as an initializer.  The command
is not called in the tree; instead, more explicit commands are used.

The jim_global_long function was not used anywhere in the tree.

diff --git a/src/helper/command.c b/src/helper/command.c
index b7c44efc91033058c43adab890945504eac0d0e5..ba689b005eec48ddbc5a31ddb2f7b9b048381313 100644 (file)
--- a/src/helper/command.c
+++ b/src/helper/command.c
@@ -44,7 +44,6 @@
 #include "jim-eventloop.h"
 
 
 #include "jim-eventloop.h"
 
 

-int fast_and_dangerous = 0;

 Jim_Interp *interp = NULL;
 
 static int run_command(struct command_context *context,
 Jim_Interp *interp = NULL;
 
 static int run_command(struct command_context *context,


@@ -141,7 +140,6 @@ static int script_command(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
 
        log_add_callback(tcl_output, tclOutput);
 
 
        log_add_callback(tcl_output, tclOutput);
 

-       // turn words[0] into CMD_ARGV[-1] with this cast

        retval = run_command(context, c, (const char **)words, nwords);
 
        log_remove_callback(tcl_output, tclOutput);
        retval = run_command(context, c, (const char **)words, nwords);
 
        log_remove_callback(tcl_output, tclOutput);


@@ -755,17 +753,6 @@ COMMAND_HANDLER(handle_sleep_command)
        return ERROR_OK;
 }
 
        return ERROR_OK;
 }
 

-COMMAND_HANDLER(handle_fast_command)
-{
-       if (CMD_ARGC != 1)
-               return ERROR_COMMAND_SYNTAX_ERROR;
-
-       fast_and_dangerous = strcmp("enable", CMD_ARGV[0]) == 0;
-
-       return ERROR_OK;
-}
-
-

 struct command_context* command_init(const char *startup_tcl)
 {
        struct command_context* context = malloc(sizeof(struct command_context));
 struct command_context* command_init(const char *startup_tcl)
 {
        struct command_context* context = malloc(sizeof(struct command_context));


@@ -839,10 +826,6 @@ struct command_context* command_init(const char *startup_tcl)
                        handle_sleep_command, COMMAND_ANY,
                        "<n> [busy] - sleep for n milliseconds. "
                        "\"busy\" means busy wait");
                        handle_sleep_command, COMMAND_ANY,
                        "<n> [busy] - sleep for n milliseconds. "
                        "\"busy\" means busy wait");

-       register_command(context, NULL, "fast",
-                       handle_fast_command, COMMAND_ANY,
-                       "fast <enable/disable> - place at beginning of "
-                       "config files. Sets defaults to fast and dangerous.");

 
        return context;
 }
 
        return context;
 }


@@ -882,18 +865,6 @@ void register_jim(struct command_context *cmd_ctx, const char *name,
        command_helptext_add(cmd_list, help);
 }
 
        command_helptext_add(cmd_list, help);
 }
 

-/* return global variable long value or 0 upon failure */
-long jim_global_long(const char *variable)
-{
-       Jim_Obj *objPtr = Jim_GetGlobalVariableStr(interp, variable, JIM_ERRMSG);
-       long t;
-       if (Jim_GetLong(interp, objPtr, &t) == JIM_OK)
-       {
-               return t;
-       }
-       return 0;
-}
-

 #define DEFINE_PARSE_NUM_TYPE(name, type, func, min, max) \
        int parse##name(const char *str, type *ul) \
        { \
 #define DEFINE_PARSE_NUM_TYPE(name, type, func, min, max) \
        int parse##name(const char *str, type *ul) \
        { \

diff --git a/src/helper/command.h b/src/helper/command.h
index a2e979708e66a3e890bd28b673abd9f18337f38f..def0935a737e7a734d22fe89015da8938b8a8ec8 100644 (file)
--- a/src/helper/command.h
+++ b/src/helper/command.h
@@ -214,15 +214,11 @@ void process_jim_events(void);
 #define                ERROR_COMMAND_ARGUMENT_OVERFLOW         (-604)
 #define                ERROR_COMMAND_ARGUMENT_UNDERFLOW        (-605)
 
 #define                ERROR_COMMAND_ARGUMENT_OVERFLOW         (-604)
 #define                ERROR_COMMAND_ARGUMENT_UNDERFLOW        (-605)
 

-extern int fast_and_dangerous;
-

 extern Jim_Interp *interp;
 
 void register_jim(struct command_context *context, const char *name,
                Jim_CmdProc cmd, const char *help);
 
 extern Jim_Interp *interp;
 
 void register_jim(struct command_context *context, const char *name,
                Jim_CmdProc cmd, const char *help);
 

-long jim_global_long(const char *variable);
-

 int parse_ulong(const char *str, unsigned long *ul);
 int parse_ullong(const char *str, unsigned long long *ul);
 
 int parse_ulong(const char *str, unsigned long *ul);
 int parse_ullong(const char *str, unsigned long long *ul);
 

diff --git a/src/target/arm7_9_common.c b/src/target/arm7_9_common.c
index 16c8a925e7bc1d56635097ec8fe6071ad9522d18..eb4b038368a09f5a5e3f5239d8366402e414c7a6 100644 (file)
--- a/src/target/arm7_9_common.c
+++ b/src/target/arm7_9_common.c
@@ -2929,8 +2929,8 @@ int arm7_9_init_arch_info(struct target *target, struct arm7_9_common *arm7_9)
 
        arm7_9->wp_available_max = 2;
 
 
        arm7_9->wp_available_max = 2;
 

-       arm7_9->fast_memory_access = fast_and_dangerous;
-       arm7_9->dcc_downloads = fast_and_dangerous;
+       arm7_9->fast_memory_access = false;
+       arm7_9->dcc_downloads = false;

 
        armv4_5->arch_info = arm7_9;
        armv4_5->read_core_reg = arm7_9_read_core_reg;
 
        armv4_5->arch_info = arm7_9;
        armv4_5->read_core_reg = arm7_9_read_core_reg;