flash/jtagspi: handle error return values where needed 22/7422/7
authorDaniel Anselmi <danselmi@gmx.ch>
Thu, 29 Dec 2022 19:02:39 +0000 (20:02 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Thu, 18 May 2023 10:20:24 +0000 (10:20 +0000)
Change-Id: Id46c2799f954fb1d4353f652ba3115796c88936d
Signed-off-by: Daniel Anselmi <danselmi@gmx.ch>
Reviewed-on: https://review.openocd.org/c/openocd/+/7422
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
src/flash/nor/jtagspi.c

index c176ca810641c6b39046955788b35bd7808532b0..0047d22bb7df01950f171382417d98decc74bd5c 100644 (file)
@@ -329,7 +329,7 @@ COMMAND_HANDLER(jtagspi_handle_cmd)
 
        /* process command */
        ptr = &read_buffer[0];
-       jtagspi_cmd(bank, write_buffer[0], &write_buffer[1], num_write - 1, ptr, -num_read);
+       retval = jtagspi_cmd(bank, write_buffer[0], &write_buffer[1], num_write - 1, ptr, -num_read);
        if (retval != ERROR_OK)
                return retval;
 
@@ -518,7 +518,7 @@ static int jtagspi_bulk_erase(struct flash_bank *bank)
        if (retval != ERROR_OK)
                return retval;
 
-       jtagspi_cmd(bank, info->dev.chip_erase_cmd, NULL, 0, NULL, 0);
+       retval = jtagspi_cmd(bank, info->dev.chip_erase_cmd, NULL, 0, NULL, 0);
        if (retval != ERROR_OK)
                return retval;
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)