dsp5680xx: disable for now, it generates warnings
authorØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 28 Jun 2011 16:35:34 +0000 (18:35 +0200)
committerØyvind Harboe <oyvind.harboe@zylin.com>
Tue, 28 Jun 2011 16:39:01 +0000 (18:39 +0200)
Use "git revert <commit>" to revert this commit, then build and
repair and post patch to the mailing list.

Warnings generated with:

nios2-elf-gcc (GCC) 3.4.6 (Altera Nios II 9.1 b222)

openocd/src/target/dsp5680xx.c: In function 'eonce_rx_upper_data':
openocd/src/target/dsp5680xx.c:252: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c: In function 'eonce_rx_lower_data':
openocd/src/target/dsp5680xx.c:268: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c: In function 'eonce_pc_store':
openocd/src/target/dsp5680xx.c:508: warning: dereferencing type-punned
pointer will break strict-aliasing rules
openocd/src/target/dsp5680xx.c: In function 'dsp5680xx_read':
openocd/src/target/dsp5680xx.c:736: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c:737: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c: In function 'dsp5680xx_write_8':
openocd/src/target/dsp5680xx.c:823: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c: In function 'dsp5680xx_write':
openocd/src/target/dsp5680xx.c:938: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c:941: warning: cast increases required
alignment of target type
openocd/src/target/dsp5680xx.c: In function 'dsp5680xx_f_wr':
openocd/src/target/dsp5680xx.c:1355: warning: cast increases required
alignment of target type

src/flash/nor/Makefile.am
src/flash/nor/drivers.c
src/target/Makefile.am
src/target/target.c

index 98460af7797780f8129e0ce825d4036d228a7b20..41fb5649f22f958f0d968c59b9b1361f8c8c9ba7 100644 (file)
@@ -30,9 +30,11 @@ NOR_DRIVERS = \
        str9x.c \
        str9xpec.c \
        tms470.c \
-       dsp5680xx_flash.c \
        virtual.c
 
+# Disabled for now, it generates warnings
+# dsp5680xx_flash.c 
+
 noinst_HEADERS = \
        core.h \
        cfi.h \
index 52febf175284fd394de5d404c6fd7437f09ebda2..637c63b1f7e8a5341ebc34a90d9d0adb46cda822 100644 (file)
@@ -43,7 +43,7 @@ extern struct flash_driver faux_flash;
 extern struct flash_driver virtual_flash;
 extern struct flash_driver stmsmi_flash;
 extern struct flash_driver em357_flash;
-extern struct flash_driver dsp5680xx_flash;
+//extern struct flash_driver dsp5680xx_flash;
 
 /**
  * The list of built-in flash drivers.
@@ -72,7 +72,8 @@ static struct flash_driver *flash_drivers[] = {
        &virtual_flash,
        &stmsmi_flash,
        &em357_flash,
-       &dsp5680xx_flash,
+       // Disabled for now, it generates warnings
+       //&dsp5680xx_flash,
        NULL,
 };
 
index 27ad054fb1a1916b69956aa53cd109765641478f..2de064633b8a3b3c576cecd86103ab6fa83fcb93 100644 (file)
@@ -33,8 +33,10 @@ libtarget_la_SOURCES = \
        $(MIPS32_SRC) \
        avrt.c \
        dsp563xx.c \
-       dsp563xx_once.c \
-       dsp5680xx.c
+       dsp563xx_once.c
+       
+# This file generates warnings, disabled for now, see also target.c
+#      dsp5680xx.c
 
 TARGET_CORE_SRC = \
        algorithm.c \
index 03431560f57cd89724937794aa749a93ffef17a6..f62915ef35ebb21240160786706c849bebb888b0 100644 (file)
@@ -81,7 +81,7 @@ extern struct target_type arm11_target;
 extern struct target_type mips_m4k_target;
 extern struct target_type avr_target;
 extern struct target_type dsp563xx_target;
-extern struct target_type dsp5680xx_target;
+//extern struct target_type dsp5680xx_target;
 extern struct target_type testee_target;
 extern struct target_type avr32_ap7k_target;
 
@@ -104,7 +104,8 @@ static struct target_type *target_types[] =
        &mips_m4k_target,
        &avr_target,
        &dsp563xx_target,
-       &dsp5680xx_target,
+// Disabled for now, it generates warnings
+//     &dsp5680xx_target,
        &testee_target,
        &avr32_ap7k_target,
        NULL,

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)