cleanup jtag minidrivers
authorZachary T Welch <zw@superlucidity.net>
Mon, 16 Nov 2009 12:29:45 +0000 (04:29 -0800)
committerZachary T Welch <zw@superlucidity.net>
Mon, 16 Nov 2009 13:30:51 +0000 (05:30 -0800)
Remove two vestigial externs from our JTAG minidriver source files.
Also, removes many extra blank lines from the minidummy driver.

src/jtag/minidummy/minidummy.c
src/jtag/zy1000/zy1000.c

index 67919e4e3070c5c24026f2e6d241326914b22805..1bee74eb18dac02b71621407c08112aa6b7dc07c 100644 (file)
@@ -24,9 +24,6 @@
 #include "minidriver.h"
 #include "interface.h"
 
-
-
-
 struct jtag_interface minidummy_interface =
 {
        .name = "minidummy",
@@ -41,11 +38,6 @@ struct jtag_interface minidummy_interface =
        .srst_asserted = NULL,
 };
 
-
-
-
-
-
 int interface_jtag_execute_queue(void)
 {
        /* synchronously do the operation here */
@@ -53,12 +45,6 @@ int interface_jtag_execute_queue(void)
        return ERROR_OK;
 }
 
-
-
-
-
-extern int jtag_check_value(uint8_t *captured, void *priv);
-
 int interface_jtag_add_ir_scan(int num_fields, const struct scan_field *fields, tap_state_t state)
 {
        /* synchronously do the operation here */
@@ -67,10 +53,6 @@ int interface_jtag_add_ir_scan(int num_fields, const struct scan_field *fields,
 
 }
 
-
-
-
-
 int interface_jtag_add_plain_ir_scan(int num_fields, const struct scan_field *fields, tap_state_t state)
 {
        /* synchronously do the operation here */
@@ -78,8 +60,6 @@ int interface_jtag_add_plain_ir_scan(int num_fields, const struct scan_field *fi
        return ERROR_OK;
 }
 
-/*extern jtag_struct command **jtag_get_last_command_p(void);*/
-
 int interface_jtag_add_dr_scan(int num_fields, const struct scan_field *fields, tap_state_t state)
 {
        /* synchronously do the operation here */
@@ -94,7 +74,6 @@ int interface_jtag_add_plain_dr_scan(int num_fields, const struct scan_field *fi
        return ERROR_OK;
 }
 
-
 int interface_jtag_add_tlr()
 {
        /* synchronously do the operation here */
@@ -102,8 +81,6 @@ int interface_jtag_add_tlr()
        return ERROR_OK;
 }
 
-
-
 int interface_jtag_add_reset(int req_trst, int req_srst)
 {
        /* synchronously do the operation here */
@@ -111,7 +88,6 @@ int interface_jtag_add_reset(int req_trst, int req_srst)
        return ERROR_OK;
 }
 
-
 int interface_jtag_add_runtest(int num_cycles, tap_state_t state)
 {
        /* synchronously do the operation here */
@@ -170,8 +146,6 @@ int interface_jtag_add_pathmove(int num_states, const tap_state_t *path)
        return ERROR_OK;
 }
 
-
-
 void embeddedice_write_dcc(struct jtag_tap *tap, int reg_addr, uint8_t *buffer, int little, int count)
 {
        int i;
@@ -181,4 +155,3 @@ void embeddedice_write_dcc(struct jtag_tap *tap, int reg_addr, uint8_t *buffer,
                buffer += 4;
        }
 }
-
index 526914afb14ad93553a6d9ce01f44cec30d07c73..9a5d2e784a4b59dc1a239884463d709ced2a61fb 100644 (file)
@@ -455,8 +455,6 @@ static void shiftValueInnerFlip(const tap_state_t state, const tap_state_t endSt
 }
 #endif
 
-extern int jtag_check_value(uint8_t *captured, void *priv);
-
 static void gotoEndState(tap_state_t end_state)
 {
        setCurrentState(end_state);
@@ -595,8 +593,6 @@ int interface_jtag_add_plain_ir_scan(int num_fields, const struct scan_field *fi
        return ERROR_OK;
 }
 
-/*extern jtag_struct command **jtag_get_last_command_p(void);*/
-
 int interface_jtag_add_dr_scan(int num_fields, const struct scan_field *fields, tap_state_t state)
 {
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)