target/xtensa: fix clang analyzer warnings 41/7141/2
authorIan Thompson <ianst@cadence.com>
Sun, 21 Aug 2022 22:56:41 +0000 (15:56 -0700)
committerAntonio Borneo <borneo.antonio@gmail.com>
Sat, 27 Aug 2022 16:20:44 +0000 (16:20 +0000)
Scan-build of target/xtensa/ has no clang analyzer warnings from xtensa source files.

Signed-off-by: Ian Thompson <ianst@cadence.com>
Change-Id: I11a125c923ece9a6fd0d9ee1698f742f88ee5cab
Reviewed-on: https://review.openocd.org/c/openocd/+/7141
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
src/target/xtensa/xtensa.c

index 4e18e3eb480ca214078cca5cb5139a70f73ad8d9..2fd2c7ca5775ba47af7a111cc779f81f8c7697f5 100644 (file)
@@ -2608,6 +2608,7 @@ static int xtensa_gdbqc_qxtreg(struct target *target, const char *packet, char *
                goto xtensa_gdbqc_qxtreg_fail;
        }
        uint8_t regbuf[XT_QUERYPKT_RESP_MAX];
+       memset(regbuf, 0, XT_QUERYPKT_RESP_MAX);
        LOG_DEBUG("TIE reg 0x%08" PRIx32 " %s (%d bytes)", regnum, iswrite ? "write" : "read", reglen);
        if (reglen * 2 + 1 > XT_QUERYPKT_RESP_MAX) {
                LOG_ERROR("TIE register too large");
@@ -2990,6 +2991,7 @@ COMMAND_HELPER(xtensa_cmd_exe_do, struct target *target)
        }
 
        uint8_t ops[32];
+       memset(ops, 0, 32);
        unsigned int oplen = parm_len / 2;
        char encoded_byte[3] = { 0, 0, 0 };
        for (unsigned int i = 0; i < oplen; i++) {

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)