Code Review / openocd.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | patch | inline | side by side (parent: ff6d070)
mips_ejtag: there is no DCR.MIPS64 bit 28/4628/6
authorJiri Kastner <cz172638@gmail.com>
Wed, 1 Aug 2018 13:17:43 +0000 (15:17 +0200)
committerOleksij Rempel <linux@rempel-privat.de>
Mon, 20 Jan 2020 06:28:49 +0000 (06:28 +0000)
available revisions (2.60, 3.10, 5.06 and 6.10) of
MD00047 (EJTAG specification), have only in IMPCODE
MIPS32/MIPS64 bit/flag.

Change-Id: If9191b6ced760c59bb7551bb041cd72b0a060bb1
Signed-off-by: Jiri Kastner <cz172638@gmail.com>
Reviewed-on: http://openocd.zylin.com/4628
Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
Tested-by: jenkins
src/target/mips_ejtag.c patch | blob | history
src/target/mips_ejtag.h patch | blob | history

diff --git a/src/target/mips_ejtag.c b/src/target/mips_ejtag.c
index 0b8122e1cf3374470e541bcfef7da20cfd2e8e12..6d35e211dde943fa39e4bd94521c5986c9660de8 100644 (file)
--- a/src/target/mips_ejtag.c
+++ b/src/target/mips_ejtag.c
@@ -349,7 +349,7 @@ static void ejtag_main_print_imp(struct mips_ejtag *ejtag_info)
                EJTAG_IMP_HAS(EJTAG_IMP_ASID6) ? " ASID_6" : "",
                EJTAG_IMP_HAS(EJTAG_IMP_MIPS16) ? " MIPS16" : "",
                EJTAG_IMP_HAS(EJTAG_IMP_NODMA) ? " noDMA" : " DMA",
-               EJTAG_IMP_HAS(EJTAG_DCR_MIPS64) ? " MIPS64" : " MIPS32");
+               EJTAG_IMP_HAS(EJTAG_IMP_MIPS64) ? " MIPS64" : " MIPS32");
 
        switch (ejtag_info->ejtag_version) {
                case EJTAG_VERSION_20:
diff --git a/src/target/mips_ejtag.h b/src/target/mips_ejtag.h
index cfba0ab561c7a80775a54cb8c37f9ed185e6a2e6..ace3d281eeb20c6b9776c35710950b10c14570b9 100644 (file)
--- a/src/target/mips_ejtag.h
+++ b/src/target/mips_ejtag.h
@@ -130,7 +130,7 @@
 /* v2.0 - 1:4 Number of Break Channels. */
 #define EJTAG_V20_IMP_BCHANNELS_MASK   0xf
 #define EJTAG_V20_IMP_BCHANNELS_SHIFT  1
-#define EJTAG_DCR_MIPS64               (1 << 0)
+#define EJTAG_IMP_MIPS64               (1 << 0)
 
 /* Debug Control Register DCR */
 #define EJTAG_DCR                              0xFF300000
Open On-Chip Debugger

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)