flash: fix FC_FLEX_RAM class code path
authorSpencer Oliver <spen@spen-soft.co.uk>
Fri, 10 Aug 2012 15:17:24 +0000 (16:17 +0100)
committerFreddie Chopin <freddie.chopin@gmail.com>
Fri, 24 Aug 2012 16:49:43 +0000 (16:49 +0000)
If the flash class was defined as FC_FLEX_RAM then this would always drop
through to the default handler.

This bug was found by clang, so untested.

Change-Id: I2d9fe6415dd216728a145519400f7b9ef1bd3c3a
Signed-off-by: Spencer Oliver <spen@spen-soft.co.uk>
Reviewed-on: http://openocd.zylin.com/773
Tested-by: jenkins
Reviewed-by: Freddie Chopin <freddie.chopin@gmail.com>
Reviewed-by: Mathias K├╝ster <kesmtp@freenet.de>
src/flash/nor/kinetis.c

index cf36104a441f6971e96054a413c23e23b0fc3425..e0bb5c20ba59784c1faf5c221ce8069bdf0b2025 100644 (file)
@@ -587,6 +587,8 @@ static int kinetis_read_part_info(struct flash_bank *bank)
                                        LOG_DEBUG("FlexRAM bank %d already configured okay",
                                                  kinfo->bank_ordinal);
                                }
                                        LOG_DEBUG("FlexRAM bank %d already configured okay",
                                                  kinfo->bank_ordinal);
                                }
+                               break;
+
                        default:
                                LOG_WARNING("Unknown or inconsistent flash class");
                                reassign = 1;
                        default:
                                LOG_WARNING("Unknown or inconsistent flash class");
                                reassign = 1;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)