Update ep93xx and at91rm9200 drivers
authorLuca Bruno <lucab@debian.org>
Mon, 27 Sep 2010 14:21:04 +0000 (16:21 +0200)
committerZachary T Welch <zwelch@codesourcery.com>
Fri, 1 Oct 2010 01:14:36 +0000 (18:14 -0700)
ep93xx and at91rm9200 are conditionally built only on arm and were not
updated to reflect changes in command registration handler.
This patch makes them properly compile again, fixing a build failure
experienced on Debian armel.

Signed-off-by: Luca Bruno <lucab@debian.org>
Signed-off-by: Zachary T Welch <zwelch@codesourcery.com>
src/jtag/drivers/at91rm9200.c
src/jtag/drivers/ep93xx.c

index 89d7000ca71e78cf8b90780130aa295dc0764c82..f7494fe3705529cbd916542d986d986e80401708 100644 (file)
@@ -118,23 +118,9 @@ static void at91rm9200_write(int tck, int tms, int tdi);
 static void at91rm9200_reset(int trst, int srst);
 
 static int at91rm9200_speed(int speed);
-static int at91rm9200_register_commands(struct command_context *cmd_ctx);
 static int at91rm9200_init(void);
 static int at91rm9200_quit(void);
 
-struct jtag_interface at91rm9200_interface =
-{
-       .name = "at91rm9200",
-
-       .supported = DEBUG_CAP_TMS_SEQ,
-       .execute_queue = bitbang_execute_queue,
-
-       .speed = at91rm9200_speed,
-       .register_commands = at91rm9200_register_commands,
-       .init = at91rm9200_init,
-       .quit = at91rm9200_quit,
-};
-
 static struct bitbang_interface at91rm9200_bitbang =
 {
        .read = at91rm9200_read,
@@ -186,7 +172,7 @@ static int at91rm9200_speed(int speed)
        return ERROR_OK;
 }
 
-static int at91rm9200_handle_device_command(struct command_context *cmd_ctx, char *cmd, char **CMD_ARGV, int argc)
+COMMAND_HANDLER(at91rm9200_handle_device_command)
 {
        if (CMD_ARGC == 0)
                return ERROR_OK;
@@ -208,12 +194,20 @@ static const struct command_registration at91rm9200_command_handlers[] = {
                .mode = COMMAND_CONFIG,
                .help = "query armjtagew info",
        },
+       COMMAND_REGISTRATION_DONE
 };
 
-static int at91rm9200_register_commands(struct command_context *cmd_ctx)
+struct jtag_interface at91rm9200_interface =
 {
-       return register_commands(cmd_ctx, NULL, at91rm9200_command_handlers);
-}
+       .name = "at91rm9200",
+
+       .execute_queue = bitbang_execute_queue,
+
+       .speed = at91rm9200_speed,
+       .commands = at91rm9200_command_handlers,
+       .init = at91rm9200_init,
+       .quit = at91rm9200_quit,
+};
 
 static int at91rm9200_init(void)
 {
index 0959a5692246138374939adf04e0be3def934a74..09312c5f85b6cdaa577787fd3e0c89f6a358351b 100644 (file)
@@ -47,7 +47,6 @@ static void ep93xx_write(int tck, int tms, int tdi);
 static void ep93xx_reset(int trst, int srst);
 
 static int ep93xx_speed(int speed);
-static int ep93xx_register_commands(struct command_context *cmd_ctx);
 static int ep93xx_init(void);
 static int ep93xx_quit(void);
 
@@ -61,7 +60,6 @@ struct jtag_interface ep93xx_interface =
        .execute_queue = bitbang_execute_queue,
 
        .speed = ep93xx_speed,
-       .register_commands = ep93xx_register_commands,
        .init = ep93xx_init,
        .quit = ep93xx_quit,
 };
@@ -123,12 +121,6 @@ static int ep93xx_speed(int speed)
        return ERROR_OK;
 }
 
-static int ep93xx_register_commands(struct command_context *cmd_ctx)
-{
-
-       return ERROR_OK;
-}
-
 static int set_gonk_mode(void)
 {
        void *syscon;

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)