target, breakpoints: improve error handling

handle_bp_command_set() showed the error message
"Failure setting breakpoint, the same address(IVA) is already used"
on any error returned from (xxx_)breakpoint_add().
Paradoxically breakpoint_add() returned ERROR_OK if it detected
duplicated bp address.
context_breakpoint_add() and hybrid_breakpoint_add() returned -1
instead of OpenOCD compatible error if they detected duplicity.

Introduce ERROR_TARGET_DUPLICATE_BREAKPOINT
Unify error handling to LOG_ERROR() any error in (xxx_)breakpoint_add()
Remove misleading error messages from handle_bp_command_set()
handle_bp_command_set() returns error if the target does not implement
add_context_breakpoint or add_hybrid_breakpoint.

Change-Id: If17dfad1756d82a77028ebdc4b305f9c8e1365ba
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4871
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>

diff --git a/src/target/breakpoints.c b/src/target/breakpoints.c
index 58bcc8615906d59de807ba6c192b522dbcb6d86a..94e8a823d07fdb225e8b3f0aed68fbf5a72added 100644 (file)
--- a/src/target/breakpoints.c
+++ b/src/target/breakpoints.c
@@ -60,9 +60,9 @@ int breakpoint_add_internal(struct target *target,
                         * breakpoint" ... check all the parameters before
                         * succeeding.
                         */
                         * breakpoint" ... check all the parameters before
                         * succeeding.
                         */

-                       LOG_DEBUG("Duplicate Breakpoint address: " TARGET_ADDR_FMT " (BP %" PRIu32 ")",
+                       LOG_ERROR("Duplicate Breakpoint address: " TARGET_ADDR_FMT " (BP %" PRIu32 ")",

                                address, breakpoint->unique_id);
                                address, breakpoint->unique_id);

-                       return ERROR_OK;
+                       return ERROR_TARGET_DUPLICATE_BREAKPOINT;

                }
                breakpoint_p = &breakpoint->next;
                breakpoint = breakpoint->next;
                }
                breakpoint_p = &breakpoint->next;
                breakpoint = breakpoint->next;


@@ -124,9 +124,9 @@ int context_breakpoint_add_internal(struct target *target,
                         * breakpoint" ... check all the parameters before
                         * succeeding.
                         */
                         * breakpoint" ... check all the parameters before
                         * succeeding.
                         */

-                       LOG_DEBUG("Duplicate Breakpoint asid: 0x%08" PRIx32 " (BP %" PRIu32 ")",
+                       LOG_ERROR("Duplicate Breakpoint asid: 0x%08" PRIx32 " (BP %" PRIu32 ")",

                                asid, breakpoint->unique_id);
                                asid, breakpoint->unique_id);

-                       return -1;
+                       return ERROR_TARGET_DUPLICATE_BREAKPOINT;

                }
                breakpoint_p = &breakpoint->next;
                breakpoint = breakpoint->next;
                }
                breakpoint_p = &breakpoint->next;
                breakpoint = breakpoint->next;


@@ -176,13 +176,13 @@ int hybrid_breakpoint_add_internal(struct target *target,
                         * breakpoint" ... check all the parameters before
                         * succeeding.
                         */
                         * breakpoint" ... check all the parameters before
                         * succeeding.
                         */

-                       LOG_DEBUG("Duplicate Hybrid Breakpoint asid: 0x%08" PRIx32 " (BP %" PRIu32 ")",
+                       LOG_ERROR("Duplicate Hybrid Breakpoint asid: 0x%08" PRIx32 " (BP %" PRIu32 ")",

                                asid, breakpoint->unique_id);
                                asid, breakpoint->unique_id);

-                       return -1;
+                       return ERROR_TARGET_DUPLICATE_BREAKPOINT;

                } else if ((breakpoint->address == address) && (breakpoint->asid == 0)) {
                } else if ((breakpoint->address == address) && (breakpoint->asid == 0)) {

-                       LOG_DEBUG("Duplicate Breakpoint IVA: " TARGET_ADDR_FMT " (BP %" PRIu32 ")",
+                       LOG_ERROR("Duplicate Breakpoint IVA: " TARGET_ADDR_FMT " (BP %" PRIu32 ")",

                                address, breakpoint->unique_id);
                                address, breakpoint->unique_id);

-                       return -1;
+                       return ERROR_TARGET_DUPLICATE_BREAKPOINT;

 
                }
                breakpoint_p = &breakpoint->next;
 
                }
                breakpoint_p = &breakpoint->next;

diff --git a/src/target/target.c b/src/target/target.c
index 7e30d789b62d9e50a0972af2219909ff8ed478fc..693eb519eb13aa1ec4c7f24ad16ad906c4084eaa 100644 (file)
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -3719,38 +3719,31 @@ static int handle_bp_command_set(struct command_context *cmd_ctx,
 
        if (asid == 0) {
                retval = breakpoint_add(target, addr, length, hw);
 
        if (asid == 0) {
                retval = breakpoint_add(target, addr, length, hw);

+               /* error is always logged in breakpoint_add(), do not print it again */

                if (ERROR_OK == retval)
                        command_print(cmd_ctx, "breakpoint set at " TARGET_ADDR_FMT "", addr);
                if (ERROR_OK == retval)
                        command_print(cmd_ctx, "breakpoint set at " TARGET_ADDR_FMT "", addr);

-               else {
-                       LOG_ERROR("Failure setting breakpoint, the same address(IVA) is already used");
-                       return retval;
-               }
+

        } else if (addr == 0) {
                if (target->type->add_context_breakpoint == NULL) {
        } else if (addr == 0) {
                if (target->type->add_context_breakpoint == NULL) {

-                       LOG_WARNING("Context breakpoint not available");
-                       return ERROR_OK;
+                       LOG_ERROR("Context breakpoint not available");
+                       return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;

                }
                retval = context_breakpoint_add(target, asid, length, hw);
                }
                retval = context_breakpoint_add(target, asid, length, hw);

+               /* error is always logged in context_breakpoint_add(), do not print it again */

                if (ERROR_OK == retval)
                        command_print(cmd_ctx, "Context breakpoint set at 0x%8.8" PRIx32 "", asid);
                if (ERROR_OK == retval)
                        command_print(cmd_ctx, "Context breakpoint set at 0x%8.8" PRIx32 "", asid);

-               else {
-                       LOG_ERROR("Failure setting breakpoint, the same address(CONTEXTID) is already used");
-                       return retval;
-               }
+

        } else {
                if (target->type->add_hybrid_breakpoint == NULL) {
        } else {
                if (target->type->add_hybrid_breakpoint == NULL) {

-                       LOG_WARNING("Hybrid breakpoint not available");
-                       return ERROR_OK;
+                       LOG_ERROR("Hybrid breakpoint not available");
+                       return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;

                }
                retval = hybrid_breakpoint_add(target, addr, asid, length, hw);
                }
                retval = hybrid_breakpoint_add(target, addr, asid, length, hw);

+               /* error is always logged in hybrid_breakpoint_add(), do not print it again */

                if (ERROR_OK == retval)
                        command_print(cmd_ctx, "Hybrid breakpoint set at 0x%8.8" PRIx32 "", asid);
                if (ERROR_OK == retval)
                        command_print(cmd_ctx, "Hybrid breakpoint set at 0x%8.8" PRIx32 "", asid);

-               else {
-                       LOG_ERROR("Failure setting breakpoint, the same address is already used");
-                       return retval;
-               }

        }
        }

-       return ERROR_OK;
+       return retval;

 }
 
 COMMAND_HANDLER(handle_bp_command)
 }
 
 COMMAND_HANDLER(handle_bp_command)

diff --git a/src/target/target.h b/src/target/target.h
index fb9d7146587362e7ded1527ce20dbc4270daf9f2..983f450ac0a69b80d4c6b6b4d64c255278d7fd6d 100644 (file)
--- a/src/target/target.h
+++ b/src/target/target.h
@@ -725,6 +725,7 @@ void target_handle_event(struct target *t, enum target_event e);
 #define ERROR_TARGET_TRANSLATION_FAULT (-309)
 #define ERROR_TARGET_NOT_RUNNING (-310)
 #define ERROR_TARGET_NOT_EXAMINED (-311)
 #define ERROR_TARGET_TRANSLATION_FAULT (-309)
 #define ERROR_TARGET_NOT_RUNNING (-310)
 #define ERROR_TARGET_NOT_EXAMINED (-311)

+#define ERROR_TARGET_DUPLICATE_BREAKPOINT (-312)

 
 extern bool get_target_reset_nag(void);
 
 
 extern bool get_target_reset_nag(void);