openrisc: restore current JTAG module while polling the CPU 63/2163/2
authorFranck Jullien <franck.jullien@gmail.com>
Mon, 9 Jun 2014 19:31:47 +0000 (21:31 +0200)
committerAndreas Fritiofson <andreas.fritiofson@gmail.com>
Sun, 22 Jun 2014 08:38:04 +0000 (08:38 +0000)
Change-Id: I93827afaa164d23a93bdddbfa864624b18473f45
Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
Reviewed-on: http://openocd.zylin.com/2163
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/target/openrisc/or1k_du_adv.c

index f497a869d4b16c510462dd65cd3fb06294aad26b..8a5562f0978897b6380b87b8f37a2754341bfdc5 100644 (file)
@@ -50,6 +50,7 @@
 #define DBG_MODULE_SELECT_REG_SIZE     2
 #define DBG_MAX_MODULES                        4
 
+#define DC_NONE                                -1
 #define DC_WISHBONE                    0
 #define DC_CPU0                                1
 #define DC_CPU1                                2
@@ -173,7 +174,7 @@ static int or1k_adv_jtag_init(struct or1k_jtag *jtag_info)
        jtag_info->or1k_jtag_inited = 1;
 
        /* TAP reset - not sure what state debug module chain is in now */
-       jtag_info->or1k_jtag_module_selected = -1;
+       jtag_info->or1k_jtag_module_selected = DC_NONE;
 
        jtag_info->current_reg_idx = malloc(DBG_MAX_MODULES * sizeof(uint8_t));
        memset(jtag_info->current_reg_idx, 0, DBG_MAX_MODULES * sizeof(uint8_t));
@@ -781,6 +782,8 @@ static int or1k_adv_is_cpu_running(struct or1k_jtag *jtag_info, int *running)
                        return retval;
        }
 
+       int current = jtag_info->or1k_jtag_module_selected;
+
        retval = adbg_select_module(jtag_info, DC_CPU0);
        if (retval != ERROR_OK)
                return retval;
@@ -795,6 +798,12 @@ static int or1k_adv_is_cpu_running(struct or1k_jtag *jtag_info, int *running)
        else
                *running = 1;
 
+       if (current != DC_NONE) {
+               retval = adbg_select_module(jtag_info, current);
+               if (retval != ERROR_OK)
+                       return retval;
+       }
+
        return ERROR_OK;
 }
 

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)