gdb_report_data_abort now ignores all target read errors, including address space...
authoroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Fri, 24 Oct 2008 07:18:13 +0000 (07:18 +0000)
committeroharboe <oharboe@b42882b7-edfa-0310-969c-e2dbd0fdcd60>
Fri, 24 Oct 2008 07:18:13 +0000 (07:18 +0000)
git-svn-id: svn://svn.berlios.de/openocd/trunk@1099 b42882b7-edfa-0310-969c-e2dbd0fdcd60

src/helper/startup.tcl
src/server/gdb_server.c

index fad7412ca20fa25eba3ca5ee3505dee8a369c70f..c98a9cf529636ce8a6bb08d88a7d8f6d0f36d827 100644 (file)
@@ -119,23 +119,23 @@ proc target_script {target_num eventname scriptname} {
     set tname [target number $target_num]
     
     if { 0 == [string compare $eventname "reset"] } {
-       $tname configure -event reset-init "script $scriptname"
-       return
+               $tname configure -event reset-init "script $scriptname"
+               return
     }
 
     if { 0 == [string compare $eventname "post_reset"] } {
-       $tname configure -event reset-init "script $scriptname"
-       return
+               $tname configure -event reset-init "script $scriptname"
+               return
     }
 
     if { 0 == [string compare $eventname "pre_reset"] } {
-       $tname configure -event reset-start "script $scriptname"
-       return
+               $tname configure -event reset-start "script $scriptname"
+               return
     }
 
     if { 0 == [string compare $eventname "gdb_program_config"] } {
-       $tname configure -event old-gdb_program_config "script $scriptname"
-       return
+               $tname configure -event old-gdb_program_config "script $scriptname"
+               return
     }
 
     return -code error "Unknown target (old) event: $eventname (try $tname configure -event NAME)"
index 52f256a5741222978ce127fd6561a555ce3ce5de..0ebe56cb49c32fdc0de18c4d8856669e3c02c2bd 100644 (file)
@@ -1138,7 +1138,7 @@ int gdb_read_memory_packet(connection_t *connection, target_t *target, char *pac
 
        retval = target_read_buffer(target, addr, len, buffer);
 
-       if ((retval == ERROR_TARGET_DATA_ABORT) && (!gdb_report_data_abort))
+       if ((retval!=ERROR_OK)&&!gdb_report_data_abort)
        {
                /* TODO : Here we have to lie and send back all zero's lest stack traces won't work.
                 * At some point this might be fixed in GDB, in which case this code can be removed.

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)