telnet_server: drop unused options 31/4131/3
authorKarl Palsson <karlp@tweak.net.au>
Wed, 10 May 2017 14:31:18 +0000 (14:31 +0000)
committerSpencer Oliver <spen@spen-soft.co.uk>
Tue, 3 Oct 2017 10:16:36 +0000 (11:16 +0100)
They're never used, so just drop them.

Change-Id: Ie137deed3e7258f9d6af7e0cb508e73df0f53ee0
Signed-off-by: Karl Palsson <karlp@tweak.net.au>
Reviewed-on: http://openocd.zylin.com/4131
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
src/server/telnet_server.c
src/server/telnet_server.h
src/target/openrisc/jsp_server.c

index e33188b5e1e0f73c2a9c289e17ce12555050a186..7507afea8d688613eeadff39940e22ba743cc911 100644 (file)
@@ -222,7 +222,6 @@ static int telnet_new_connection(struct connection *connection)
        telnet_connection->closed = 0;
        telnet_connection->line_size = 0;
        telnet_connection->line_cursor = 0;
-       telnet_connection->option_size = 0;
        telnet_connection->prompt = strdup("> ");
        telnet_connection->state = TELNET_STATE_DATA;
 
index 04ba965708c49f85d5ab658fc3c60e22cf187af8..e43d6bcf8e31caa636ec8f7cb22f71463e4fca18 100644 (file)
@@ -29,7 +29,6 @@
 
 #define TELNET_BUFFER_SIZE (1024)
 
-#define TELNET_OPTION_MAX_SIZE (128)
 #define TELNET_LINE_HISTORY_SIZE (128)
 #define TELNET_LINE_MAX_SIZE (256)
 
@@ -51,8 +50,6 @@ struct telnet_connection {
        char line[TELNET_LINE_MAX_SIZE];
        int line_size;
        int line_cursor;
-       char option[TELNET_OPTION_MAX_SIZE];
-       int option_size;
        char last_escape;
        char *history[TELNET_LINE_HISTORY_SIZE];
        int next_history;
index e581fb870e84ac37f90fcf7d9df335b50d5b594f..2d90114faa799ce0503431549b0c7cf79ea2483b 100644 (file)
@@ -88,7 +88,6 @@ static int jsp_new_connection(struct connection *connection)
        telnet_connection->closed = 0;
        telnet_connection->line_size = 0;
        telnet_connection->line_cursor = 0;
-       telnet_connection->option_size = 0;
        telnet_connection->state = TELNET_STATE_DATA;
 
        /* negotiate telnet options */

Linking to existing account procedure

If you already have an account and want to add another login method you MUST first sign in with your existing account and then change URL to read https://review.openocd.org/login/?link to get to this page again but this time it'll work for linking. Thank you.

SSH host keys fingerprints

1024 SHA256:YKx8b7u5ZWdcbp7/4AeXNaqElP49m6QrwfXaqQGJAOk gerrit-code-review@openocd.zylin.com (DSA)
384 SHA256:jHIbSQa4REvwCFG4cq5LBlBLxmxSqelQPem/EXIrxjk gerrit-code-review@openocd.org (ECDSA)
521 SHA256:UAOPYkU9Fjtcao0Ul/Rrlnj/OsQvt+pgdYSZ4jOYdgs gerrit-code-review@openocd.org (ECDSA)
256 SHA256:A13M5QlnozFOvTllybRZH6vm7iSt0XLxbA48yfc2yfY gerrit-code-review@openocd.org (ECDSA)
256 SHA256:spYMBqEYoAOtK7yZBrcwE8ZpYt6b68Cfh9yEVetvbXg gerrit-code-review@openocd.org (ED25519)
+--[ED25519 256]--+
|=..              |
|+o..   .         |
|*.o   . .        |
|+B . . .         |
|Bo. = o S        |
|Oo.+ + =         |
|oB=.* = . o      |
| =+=.+   + E     |
|. .=o   . o      |
+----[SHA256]-----+
2048 SHA256:0Onrb7/PHjpo6iVZ7xQX2riKN83FJ3KGU0TvI0TaFG4 gerrit-code-review@openocd.zylin.com (RSA)