From: Evgeniy Naydanov Date: Wed, 14 Sep 2022 14:56:20 +0000 (+0300) Subject: Remove duplicate of a counter in hwthread_update_threads X-Git-Tag: v0.12.0-rc2~31 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=0cedf10f8fd618b78190ce32a40f26dec0fb8253;ds=sidebyside Remove duplicate of a counter in hwthread_update_threads There is no need to count number of examined threads twice. Signed-off-by: Evgeniy Naydanov Change-Id: Id32ead853d1ddcd4e67062d6f795700feb20cb4b Reviewed-on: https://review.openocd.org/c/openocd/+/7223 Tested-by: jenkins Reviewed-by: Antonio Borneo Reviewed-by: Tomas Vanek --- diff --git a/src/rtos/hwthread.c b/src/rtos/hwthread.c index e5eaf425f6..bdd5835c27 100644 --- a/src/rtos/hwthread.c +++ b/src/rtos/hwthread.c @@ -78,7 +78,6 @@ static int hwthread_fill_thread(struct rtos *rtos, struct target *curr, int thre static int hwthread_update_threads(struct rtos *rtos) { int threads_found = 0; - int thread_list_size = 0; struct target_list *head; struct target *target; int64_t current_thread = 0; @@ -100,13 +99,13 @@ static int hwthread_update_threads(struct rtos *rtos) if (!target_was_examined(curr)) continue; - ++thread_list_size; + ++threads_found; } } else - thread_list_size = 1; + threads_found = 1; /* create space for new thread details */ - rtos->thread_details = malloc(sizeof(struct thread_detail) * thread_list_size); + rtos->thread_details = malloc(sizeof(struct thread_detail) * threads_found); if (target->smp) { /* loop over all threads */ @@ -171,13 +170,10 @@ static int hwthread_update_threads(struct rtos *rtos) default: break; } - - threads_found++; } } else { hwthread_fill_thread(rtos, target, threads_found); current_thread = threadid_from_target(target); - threads_found++; } rtos->thread_count = threads_found;