From: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Date: Sun, 6 Dec 2015 15:29:36 +0000 (+0100)
Subject: adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck
X-Git-Tag: v0.10.0-rc1~306
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=1d17b32829e1b89d5d9c045c7b7b3ceb98e5f4f4

adi_v5_jtag: Remove TAR and CSW prints from jtagdp_transaction_endcheck

The AP for which the TAR/CSW is printed may not be the one that caused
the failure. Remove the flawed output entirely. The correct info is
printed in mem_ap_read/write anyway.

Change-Id: I97580a0662dcf02e80646e45445cdbfc251122d8
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/3154
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
---

diff --git a/src/target/adi_v5_jtag.c b/src/target/adi_v5_jtag.c
index 3ab53994e1..2753713c36 100644
--- a/src/target/adi_v5_jtag.c
+++ b/src/target/adi_v5_jtag.c
@@ -274,21 +274,6 @@ static int jtagdp_transaction_endcheck(struct adiv5_dap *dap)
 			LOG_ERROR("Debug regions are unpowered, an unexpected reset might have happened");
 			return ERROR_JTAG_DEVICE_ERROR;
 		} else {
-			uint32_t mem_ap_csw, mem_ap_tar;
-
-			/* Maybe print information about last intended
-			 * MEM-AP access; but not if autoincrementing.
-			 * *Real* CSW and TAR values are always shown.
-			 */
-			if (dap->ap[dap_ap_get_select(dap)].tar_value != (uint32_t) -1)
-				LOG_DEBUG("MEM-AP Cached values: "
-					"ap_bank 0x%" PRIx32
-					", ap_csw 0x%" PRIx32
-					", ap_tar 0x%" PRIx32,
-					dap->ap_bank_value,
-					dap->ap[dap_ap_get_select(dap)].csw_value,
-					dap->ap[dap_ap_get_select(dap)].tar_value);
-
 			if (ctrlstat & SSTICKYORUN)
 				LOG_ERROR("JTAG-DP OVERRUN - check clock, "
 					"memaccess, or reduce jtag speed");
@@ -312,23 +297,6 @@ static int jtagdp_transaction_endcheck(struct adiv5_dap *dap)
 				return retval;
 
 			LOG_DEBUG("jtag-dp: CTRL/STAT 0x%" PRIx32, ctrlstat);
-
-			retval = dap_queue_ap_read(dap,
-					MEM_AP_REG_CSW, &mem_ap_csw);
-			if (retval != ERROR_OK)
-				return retval;
-
-			retval = dap_queue_ap_read(dap,
-					MEM_AP_REG_TAR, &mem_ap_tar);
-			if (retval != ERROR_OK)
-				return retval;
-
-			retval = jtag_execute_queue();
-			if (retval != ERROR_OK)
-				return retval;
-			LOG_ERROR("MEM_AP_CSW 0x%" PRIx32 ", MEM_AP_TAR 0x%"
-					PRIx32, mem_ap_csw, mem_ap_tar);
-
 		}
 		retval = jtag_execute_queue();
 		if (retval != ERROR_OK)