From: Andreas Fritiofson Date: Fri, 20 Sep 2013 21:06:24 +0000 (+0200) Subject: target: Fix strange ordering in target_read_u8 X-Git-Tag: v0.8.0-rc1~244 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=322f7dcceab2b1a7363c722d80571a5fd8637328 target: Fix strange ordering in target_read_u8 It's been like this since the check was added, in 5aa93a5e. Change-Id: Iaa0586e0cd1ce57ad92735dcc3e51108a133fe96 Signed-off-by: Andreas Fritiofson Reviewed-on: http://openocd.zylin.com/1640 Tested-by: jenkins Reviewed-by: Spencer Oliver --- diff --git a/src/target/target.c b/src/target/target.c index fce1cd42df..4a8d9aaafb 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -2031,12 +2031,13 @@ int target_read_u16(struct target *target, uint32_t address, uint16_t *value) int target_read_u8(struct target *target, uint32_t address, uint8_t *value) { - int retval = target_read_memory(target, address, 1, 1, value); if (!target_was_examined(target)) { LOG_ERROR("Target not examined yet"); return ERROR_FAIL; } + int retval = target_read_memory(target, address, 1, 1, value); + if (retval == ERROR_OK) { LOG_DEBUG("address: 0x%8.8" PRIx32 ", value: 0x%2.2x", address,