From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Sun, 23 Oct 2011 04:12:57 +0000 (+0800)
Subject: NOR/CORE: fix clang warning
X-Git-Tag: v0.6.0-rc1~507
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=40c425e4005b6c00cab3ff2cd620cd3d6ae66514;ds=inline

NOR/CORE: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I10338a249bcfeff87d8596f7e17f209e26b41678
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/86
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
---

diff --git a/src/flash/nor/core.c b/src/flash/nor/core.c
index 4b5fe7dd84..7f40bbff03 100644
--- a/src/flash/nor/core.c
+++ b/src/flash/nor/core.c
@@ -344,7 +344,8 @@ int default_flash_blank_check(struct flash_bank *bank)
 		uint32_t address = bank->base + bank->sectors[i].offset;
 		uint32_t size = bank->sectors[i].size;
 
-		if ((retval = target_blank_check_memory(target, address, size, &blank)) != ERROR_OK)
+		retval = target_blank_check_memory(target, address, size, &blank);
+		if (retval != ERROR_OK)
 		{
 			fast_check = 0;
 			break;