From: Vandra Akos Date: Wed, 23 May 2012 10:47:55 +0000 (+0200) Subject: Jim_GetResult was called twice X-Git-Tag: v0.6.0-rc1~60 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=445a54a669da05511d45dfcebad5823c2db2f321;hp=c3074f377c1da33ca8ba8493826e1b52351eebc6 Jim_GetResult was called twice Removed the superflous call to Jim_GetResult, as we are reading in the result to a variable anyways in the next instruction. Change-Id: Idc96400737dc15e28304e97bcea79fa6c7a88ae1 Signed-off-by: Vandra Akos Reviewed-on: http://openocd.zylin.com/661 Tested-by: jenkins Reviewed-by: Øyvind Harboe Reviewed-by: Spencer Oliver --- diff --git a/src/server/tcl_server.c b/src/server/tcl_server.c index 30d55cbc34..94c3454ad0 100644 --- a/src/server/tcl_server.c +++ b/src/server/tcl_server.c @@ -129,9 +129,8 @@ static int tcl_input(struct connection *connection) tclc->tc_line[tclc->tc_lineoffset-1] = '\0'; LOG_DEBUG("Executing script:\n %s", tclc->tc_line); retval = Jim_Eval_Named(interp, tclc->tc_line, "remote:connection", 1); - LOG_DEBUG("Result: %d\n %s", retval, - Jim_GetString(Jim_GetResult(interp), &reslen)); result = Jim_GetString(Jim_GetResult(interp), &reslen); + LOG_DEBUG("Result: %d\n %s", retval, result); retval = tcl_output(connection, result, reslen); if (retval != ERROR_OK) return retval;