From: Marc Schink Date: Thu, 17 Jun 2021 13:47:11 +0000 (+0200) Subject: target/dsp563xx: Handle return values X-Git-Tag: v0.12.0-rc1~670 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=56b72b33cfc7014e001fa9e209b62f4b6c009fb5 target/dsp563xx: Handle return values This fixes 'dead assignment' bugs identified by the clang static analyzer. Change-Id: I140ed55f0043e06a533f45f50a36887614585b04 Signed-off-by: Marc Schink Reviewed-on: http://openocd.zylin.com/6323 Tested-by: jenkins Reviewed-by: Antonio Borneo --- diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c index 81ea21e813..7305733479 100644 --- a/src/target/dsp563xx.c +++ b/src/target/dsp563xx.c @@ -1085,8 +1085,17 @@ static int dsp563xx_poll(struct target *target) if (!dsp563xx->hardware_breakpoints_cleared) { err = dsp563xx_once_reg_write(target->tap, 1, DSP563XX_ONCE_OBCR, 0); + if (err != ERROR_OK) + return err; + err = dsp563xx_once_reg_write(target->tap, 1, DSP563XX_ONCE_OMLR0, 0); + if (err != ERROR_OK) + return err; + err = dsp563xx_once_reg_write(target->tap, 1, DSP563XX_ONCE_OMLR1, 0); + if (err != ERROR_OK) + return err; + dsp563xx->hardware_breakpoints_cleared = 1; }