From: Andreas Fritiofson Date: Sat, 28 Sep 2013 21:33:59 +0000 (+0200) Subject: ftdi: Remove unnecessary cast X-Git-Tag: v0.8.0-rc1~190 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=582c8b014727f27a078302e684ba661a9a081963 ftdi: Remove unnecessary cast Also make sure future growth of the tap_get_tms_path() return value will get noticed. Change-Id: Id859b463e5fdc819a4bc3b4845bf4363fbe713af Signed-off-by: Andreas Fritiofson Reviewed-on: http://openocd.zylin.com/1768 Tested-by: jenkins Reviewed-by: Mathias Küster Reviewed-by: Spencer Oliver --- diff --git a/src/jtag/drivers/ftdi.c b/src/jtag/drivers/ftdi.c index 4566ed3cf8..a6070b1120 100644 --- a/src/jtag/drivers/ftdi.c +++ b/src/jtag/drivers/ftdi.c @@ -205,8 +205,9 @@ static void move_to_state(tap_state_t goal_state) */ /* do the 2 lookups */ - int tms_bits = tap_get_tms_path(start_state, goal_state); + uint8_t tms_bits = tap_get_tms_path(start_state, goal_state); int tms_count = tap_get_tms_path_len(start_state, goal_state); + assert(tms_count <= 8); DEBUG_JTAG_IO("start=%s goal=%s", tap_state_name(start_state), tap_state_name(goal_state)); @@ -215,7 +216,7 @@ static void move_to_state(tap_state_t goal_state) tap_set_state(tap_state_transition(tap_get_state(), (tms_bits >> i) & 1)); mpsse_clock_tms_cs_out(mpsse_ctx, - (uint8_t *)&tms_bits, + &tms_bits, 0, tms_count, false,