From: Andreas Fritiofson Date: Thu, 23 Aug 2012 21:35:48 +0000 (+0200) Subject: ftdi: fix overflow if last field of a scan is empty X-Git-Tag: v0.6.0-rc2~5 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=6055d952c3efd2e6b12924c5ec42407fff99b453;hp=d9a02fda075c466dd4a37785d886a4b1ee382242;ds=sidebyside ftdi: fix overflow if last field of a scan is empty The last bit of a scan is clocked during TAP movement so it's necessary for the last field to have at least one bit. Strip trailing empty fields and make sure the TAP is not affected if there's nothing to scan. Clients probably shouldn't add empty fields so add a debug message to be able to track and fix them. Change-Id: I27552568bc11146570b9b99ed8a1ae81b5fb2c50 Signed-off-by: Andreas Fritiofson Reviewed-on: http://openocd.zylin.com/794 Reviewed-by: Spencer Oliver Tested-by: jenkins Reviewed-by: Freddie Chopin --- diff --git a/src/jtag/drivers/ftdi.c b/src/jtag/drivers/ftdi.c index 72b08fd4c9..46797d7dfe 100644 --- a/src/jtag/drivers/ftdi.c +++ b/src/jtag/drivers/ftdi.c @@ -389,6 +389,18 @@ static int ftdi_execute_scan(struct jtag_command *cmd) DEBUG_JTAG_IO("%s type:%d", cmd->cmd.scan->ir_scan ? "IRSCAN" : "DRSCAN", jtag_scan_type(cmd->cmd.scan)); + /* Make sure there are no trailing fields with num_bits == 0, or the logic below will fail. */ + while (cmd->cmd.scan->num_fields > 0 + && cmd->cmd.scan->fields[cmd->cmd.scan->num_fields - 1].num_bits == 0) { + cmd->cmd.scan->num_fields--; + LOG_DEBUG("discarding trailing empty field"); + } + + if (cmd->cmd.scan->num_fields == 0) { + LOG_DEBUG("empty scan, doing nothing"); + return retval; + } + if (cmd->cmd.scan->ir_scan) { if (tap_get_state() != TAP_IRSHIFT) move_to_state(TAP_IRSHIFT); @@ -413,7 +425,7 @@ static int ftdi_execute_scan(struct jtag_command *cmd) if (i == cmd->cmd.scan->num_fields - 1 && tap_get_state() != tap_get_end_state()) { /* Last field, and we're leaving IRSHIFT/DRSHIFT. Clock last bit during tap - *movement */ + * movement. This last field can't have length zero, it was checked above. */ mpsse_clock_data(mpsse_ctx, field->out_value, 0,