From: Antonio Borneo Date: Sat, 10 Apr 2010 12:08:41 +0000 (+0800) Subject: NAND/CORE: review scope of functions X-Git-Tag: v0.5.0-rc1~766 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=617811ac664504303cf65a69c1b3f8ca262def0b NAND/CORE: review scope of functions Add "static" qualifier to private functions. Move function's comment from core.h to core.c. Signed-off-by: Antonio Borneo --- diff --git a/src/flash/nand/core.c b/src/flash/nand/core.c index 50d8249462..9013812d28 100644 --- a/src/flash/nand/core.c +++ b/src/flash/nand/core.c @@ -160,7 +160,14 @@ static struct nand_ecclayout nand_oob_8 = { }; #endif -struct nand_device *get_nand_device_by_name(const char *name) +/** + * Returns the flash bank specified by @a name, which matches the + * driver name and a suffix (option) specify the driver-specific + * bank number. The suffix consists of the '.' and the driver-specific + * bank number: when two davinci banks are defined, then 'davinci.1' refers + * to the second (e.g. DM355EVM). + */ +static struct nand_device *get_nand_device_by_name(const char *name) { unsigned requested = get_flash_name_index(name); unsigned found = 0; diff --git a/src/flash/nand/core.h b/src/flash/nand/core.h index d2d1571513..e4fb18bb9a 100644 --- a/src/flash/nand/core.h +++ b/src/flash/nand/core.h @@ -197,15 +197,6 @@ enum oob_formats }; -/** - * Returns the flash bank specified by @a name, which matches the - * driver name and a suffix (option) specify the driver-specific - * bank number. The suffix consists of the '.' and the driver-specific - * bank number: when two davinci banks are defined, then 'davinci.1' refers - * to the second (e.g. DM355EVM). - */ -struct nand_device *get_nand_device_by_name(const char *name); - struct nand_device *get_nand_device_by_num(int num); int nand_page_command(struct nand_device *nand, uint32_t page,