From: Girts Folkmanis <girtsf@users.noreply.github.com>
Date: Fri, 3 Mar 2017 17:49:58 +0000 (-0800)
Subject: arm_dpm: fix dpm setup
X-Git-Tag: v0.11.0-rc1~1436
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=6b2acc0243f6dd54823c336ded8c20d16cdc50a3;hp=77189db85630cef21a4887a9b1c15dac3fd48473

arm_dpm: fix dpm setup

When ARM64 support was being merged, a comparison ended up being
inverted. This causes NULL pointer access when target attempts to
use core cache.

Change-Id: Ic8873ddd13dbdd8100856a71b4717f44cd336e23
Signed-off-by: Girts Folkmanis <opensource@girts.me>
Signed-off-by: Matthias Welwarsky <matthias.welwarsky@sysgo.com>
Reviewed-on: http://openocd.zylin.com/4042
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
Tested-by: jenkins
Reviewed-by: Paul Fertser <fercerpav@gmail.com>
---

diff --git a/src/target/arm_dpm.c b/src/target/arm_dpm.c
index f15bff7546..3e8180c36d 100644
--- a/src/target/arm_dpm.c
+++ b/src/target/arm_dpm.c
@@ -973,7 +973,7 @@ int arm_dpm_setup(struct arm_dpm *dpm)
 	arm->read_core_reg = arm_dpm_read_core_reg;
 	arm->write_core_reg = arm_dpm_write_core_reg;
 
-	if (arm->core_cache != NULL) {
+	if (arm->core_cache == NULL) {
 		cache = arm_build_reg_cache(target, arm);
 		if (!cache)
 			return ERROR_FAIL;