From: Øyvind Harboe <oyvind.harboe@zylin.com>
Date: Sat, 21 Nov 2009 22:29:58 +0000 (+0100)
Subject: embedded: reduce stack usage
X-Git-Tag: v0.4.0-rc1~456
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=700a60ec573e9cfdbcac3c1c30ee5e94aeddfa6a

embedded: reduce stack usage

Allocate working structures on stack to avoid issues with
path lengths + reduce stack usage.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
---

diff --git a/src/helper/configuration.c b/src/helper/configuration.c
index 2ea5da480c..007246c58b 100644
--- a/src/helper/configuration.c
+++ b/src/helper/configuration.c
@@ -61,21 +61,23 @@ char *find_file(const char *file)
 	char **search_dirs = script_search_dirs;
 	char *dir;
 	char const *mode="r";
-	char full_path[1024];
+	char *full_path;
 
 	/* Check absolute and relative to current working dir first.
 	 * This keeps full_path reporting belowing working. */
-	snprintf(full_path, 1024, "%s", file);
+	full_path = alloc_printf("%s", file);
 	fp = fopen(full_path, mode);
 
 	while (!fp)
 	{
+		free(full_path);
+		full_path = NULL;
 		dir = *search_dirs++;
 
 		if (!dir)
 			break;
 
-		snprintf(full_path, 1024, "%s/%s", dir, file);
+		full_path = alloc_printf("%s/%s", dir, file);
 		fp = fopen(full_path, mode);
 	}
 
@@ -83,8 +85,11 @@ char *find_file(const char *file)
 	{
 		fclose(fp);
 		LOG_DEBUG("found %s", full_path);
-		return strdup(full_path);
+		return full_path;
 	}
+
+	free(full_path);
+
 	return NULL;
 }