From: Alamy Liu <alamy.liu@gmail.com>
Date: Thu, 6 Aug 2015 21:45:19 +0000 (-0700)
Subject: flash/nor/jtagspi: 'retval' may be used uninitialized
X-Git-Tag: v0.10.0-rc1~452
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=85903156d70aec211b3c66326aeffc6ceba6ebb4

flash/nor/jtagspi: 'retval' may be used uninitialized

Problem
As my compiler has "warnings being treated as errors" on, it shows the
error message:
  error: 'retval' may be used uninitialized in this function

Investigation
Nothing wrong with the logic, 'retval' would have a value before returning.
Just wanna get rid of the compiling "warning as error" message.

Solution
Provide a reasonable default value

Change-Id: I712c15f82819c6c48bee9dceca8de4b18aeb29b0
Signed-off-by: Alamy Liu <alamy.liu@gmail.com>
Reviewed-on: http://openocd.zylin.com/2905
Tested-by: jenkins
Reviewed-by: Robert Jordens <jordens@gmail.com>
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
---

diff --git a/src/flash/nor/jtagspi.c b/src/flash/nor/jtagspi.c
index 6ca5c3c25e..1e623a71b6 100644
--- a/src/flash/nor/jtagspi.c
+++ b/src/flash/nor/jtagspi.c
@@ -272,7 +272,7 @@ static int jtagspi_erase(struct flash_bank *bank, int first, int last)
 {
 	int sector;
 	struct jtagspi_flash_bank *info = bank->driver_priv;
-	int retval;
+	int retval = ERROR_OK;
 
 	LOG_DEBUG("erase from sector %d to sector %d", first, last);