From: Antonio Borneo <borneo.antonio@gmail.com>
Date: Sun, 23 Oct 2011 04:16:26 +0000 (+0800)
Subject: SERVER: fix clang warning
X-Git-Tag: v0.6.0-rc1~505
X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=8e8ff02b74fd98fcff080ecb081312d2a08f314e

SERVER: fix clang warning

The fix is inline with the Linux coding style that forbids
assignment in if condition

Change-Id: I0b9d0b419d9c8b7a8c755e048d5faf72d1658ba2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/87
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
---

diff --git a/src/server/server.c b/src/server/server.c
index bb60fc5742..a7fddf6749 100644
--- a/src/server/server.c
+++ b/src/server/server.c
@@ -487,7 +487,8 @@ int server_loop(struct command_context *command_context)
 				{
 					if ((FD_ISSET(c->fd, &read_fds)) || c->input_pending)
 					{
-						if ((retval = service->input(c)) != ERROR_OK)
+						retval = service->input(c);
+						if (retval != ERROR_OK)
 						{
 							struct connection *next = c->next;
 							if (service->type == CONNECTION_PIPE)