From: Jussi Kivilinna Date: Wed, 17 Dec 2014 10:14:32 +0000 (+0200) Subject: stm32lx: do not attempt mass-erase in-place of first bank erase X-Git-Tag: v0.9.0-rc1~157 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=a9c90a0f8f9080d185233e4037e9c88075366fcb;hp=873774992d8739cf08095a03d55fec49cd4b5987 stm32lx: do not attempt mass-erase in-place of first bank erase Commit 832f0a5bfb439 'stm32: add mass erase support for STM32L' added use of mass-erase in-place of bank-erase. This is triggered if first bank is requested to be fully erased. This erroneous action completely fails on STM32L162VEY (has 512 KiB flash in two 256 KiB banks) and also unintently destroying contents of EEPROM and second flash bank. Change-Id: I0f13f7b0346747a09c755d72b5b95775ceff5a6f Signed-off-by: Jussi Kivilinna Reviewed-on: http://openocd.zylin.com/2441 Reviewed-by: Paul Fertser Tested-by: jenkins --- diff --git a/src/flash/nor/stm32lx.c b/src/flash/nor/stm32lx.c index db3897ba66..061ccb9e99 100644 --- a/src/flash/nor/stm32lx.c +++ b/src/flash/nor/stm32lx.c @@ -307,9 +307,6 @@ static int stm32lx_erase(struct flash_bank *bank, int first, int last) return ERROR_TARGET_NOT_HALTED; } - if ((first == 0) && (last == (bank->num_sectors - 1))) - return stm32lx_mass_erase(bank); - /* * Loop over the selected sectors and erase them */