From: Spencer Oliver Date: Wed, 23 Nov 2011 23:39:57 +0000 (+0000) Subject: target: fix init_targets script handling X-Git-Tag: v0.6.0-rc1~400 X-Git-Url: https://review.openocd.org/gitweb?p=openocd.git;a=commitdiff_plain;h=b46231669928bf4edb48c50b327cb68b0d01a27e target: fix init_targets script handling This fixes an issue when init is called before init_targets has been executed. Make sure init_targets is called before init. Change-Id: Icd5bd4c2a8eea2e399d9de4e331a77560e9672ac Signed-off-by: Spencer Oliver Reviewed-on: http://openocd.zylin.com/235 Tested-by: jenkins Reviewed-by: Peter Stuge --- diff --git a/src/openocd.c b/src/openocd.c index 2c27fc4214..66555e60b1 100644 --- a/src/openocd.c +++ b/src/openocd.c @@ -292,10 +292,6 @@ static int openocd_thread(int argc, char *argv[], struct command_context *cmd_ct if (ERROR_OK != ret) return EXIT_FAILURE; - ret = command_run_line(cmd_ctx, "init_targets"); - if (ERROR_OK != ret) - ret = EXIT_FAILURE; - if (init_at_startup) { ret = command_run_line(cmd_ctx, "init"); diff --git a/src/target/target.c b/src/target/target.c index 4708a1d626..bcd00a1fbe 100644 --- a/src/target/target.c +++ b/src/target/target.c @@ -1043,6 +1043,8 @@ static int target_init(struct command_context *cmd_ctx) COMMAND_HANDLER(handle_target_init_command) { + int retval; + if (CMD_ARGC != 0) return ERROR_COMMAND_SYNTAX_ERROR; @@ -1054,6 +1056,10 @@ COMMAND_HANDLER(handle_target_init_command) } target_initialized = true; + retval = command_run_line(CMD_CTX, "init_targets"); + if (ERROR_OK != retval) + return retval; + LOG_DEBUG("Initializing targets..."); return target_init(CMD_CTX); }