From 57aa19f8460682a41f87b9f7d685278775fff6db Mon Sep 17 00:00:00 2001 From: Freddie Chopin Date: Tue, 17 Jul 2012 09:49:37 +0200 Subject: [PATCH] Update HACKING info MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Inform about possibility of discarding negative review in Gerrit when specific conditions are met. Change-Id: I432b6c93cefc368fa22ce1096bea4cd174e03816 Signed-off-by: Freddie Chopin Reviewed-on: http://openocd.zylin.com/747 Reviewed-by: Øyvind Harboe Tested-by: Øyvind Harboe --- HACKING | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/HACKING b/HACKING index 2bd3114275..d4f7a79f8c 100644 --- a/HACKING +++ b/HACKING @@ -152,6 +152,13 @@ master branch will be much reduced. If a contributor pushes a patch, it is considered good form if another contributor actually approves and submits that patch. +It should be noted that a negative review in Gerrit ("-1" or "-2") may (but does +not have to) be disregarded if all conditions listed below are met: + +- the concerns raised in the review have been addressed (or explained), +- reviewer does not re-examine the change in a month, +- reviewer does not answer e-mails for another month. + @section browsing Browsing Patches All OpenOCD patches can be reviewed here. */ -- 2.30.2