From 5d1a9033ab89b017c95e79590d76abbfa61f7512 Mon Sep 17 00:00:00 2001 From: David Brownell Date: Sun, 15 Nov 2009 10:35:47 -0800 Subject: [PATCH] ARM11: use now-generic memory utils Now the ARM11 cores can use the renamed arm_checksum_memory() and arm_blank_check_memory() routines ... do so. Sanity checked with "flash erase_check" of both NOR banks on an OMAP2420 ... the algorithm code dumped four lines of of "poll" status after each of almost 520 blocks (yes, *very* annoying) but gave plausible results after producing that spam. Signed-off-by: David Brownell --- NEWS | 8 ++++++++ src/target/arm11.c | 13 ++----------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/NEWS b/NEWS index 813ecda43d..7387d70574 100644 --- a/NEWS +++ b/NEWS @@ -8,8 +8,16 @@ JTAG Layer: Boundary Scan: Target Layer: + ARM11 + - Preliminary ETM and ETB hookup + - accelerated "flash erase_check" + - accelerated GDB memory checksum + Flash Layer: Board, Target, and Interface Configuration Scripts: + ARM9 + - ETM and ETB hookup for iMX2* targets + Documentation: Build and Release: diff --git a/src/target/arm11.c b/src/target/arm11.c index 0b2fa2cf5e..348dd8755f 100644 --- a/src/target/arm11.c +++ b/src/target/arm11.c @@ -1551,16 +1551,6 @@ static int arm11_bulk_write_memory(struct target *target, return arm11_write_memory(target, address, 4, count, buffer); } -/* here we have nothing target specific to contribute, so we fail and then the - * fallback code will read data from the target and calculate the CRC on the - * host. - */ -static int arm11_checksum_memory(struct target *target, - uint32_t address, uint32_t count, uint32_t* checksum) -{ - return ERROR_FAIL; -} - /* target break-/watchpoint control * rw: 0 = write, 1 = read, 2 = access */ @@ -2203,7 +2193,8 @@ struct target_type arm11_target = { .bulk_write_memory = arm11_bulk_write_memory, - .checksum_memory = arm11_checksum_memory, + .checksum_memory = arm_checksum_memory, + .blank_check_memory = arm_blank_check_memory, .add_breakpoint = arm11_add_breakpoint, .remove_breakpoint = arm11_remove_breakpoint, -- 2.30.2