From 7b94f4c99d7f7970c4f8bf51d477d88b93a4278c Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Sun, 23 Oct 2011 12:02:57 +0800 Subject: [PATCH] NAND/CORE: fix clang warning MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The fix is inline with the Linux coding style that forbids assignment in if condition Change-Id: I42a371d6adfdf3b3fb867705211c47d89776ee2a Signed-off-by: Antonio Borneo Reviewed-on: http://openocd.zylin.com/85 Tested-by: jenkins Reviewed-by: Øyvind Harboe --- src/flash/nand/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/flash/nand/core.c b/src/flash/nand/core.c index 03deabd4b2..d9bb7dea92 100644 --- a/src/flash/nand/core.c +++ b/src/flash/nand/core.c @@ -598,7 +598,8 @@ int nand_erase(struct nand_device *nand, int first_block, int last_block) return ERROR_NAND_OPERATION_TIMEOUT; } - if ((retval = nand_read_status(nand, &status)) != ERROR_OK) + retval = nand_read_status(nand, &status); + if (retval != ERROR_OK) { LOG_ERROR("couldn't read status"); return ERROR_NAND_OPERATION_FAILED; -- 2.30.2