From 8f1971295b251dc13b687db493c2daa7f922e940 Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Wed, 22 Sep 2021 19:21:39 +0200 Subject: [PATCH] mips64_pracc: fix three dead assignments Clang scan-build complains for three dead assignments: Although the value stored to 'data' is used in the enclosing expression, the value is never actually read from 'data' Value stored to 'address' is never read Remove the useless assignment and the variable 'data'. Change-Id: Ie8dcb74b1c1aa5eea1acd06b3c45c5b44954c9e7 Signed-off-by: Antonio Borneo Reviewed-on: https://review.openocd.org/c/openocd/+/6592 Tested-by: jenkins --- src/target/mips64_pracc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/target/mips64_pracc.c b/src/target/mips64_pracc.c index 9583ad767e..bb2af228d3 100644 --- a/src/target/mips64_pracc.c +++ b/src/target/mips64_pracc.c @@ -213,7 +213,7 @@ int mips64_pracc_exec(struct mips_ejtag *ejtag_info, unsigned num_param_out, uint64_t *param_out) { uint32_t ejtag_ctrl; - uint64_t address = 0, address_prev = 0, data; + uint64_t address = 0, address_prev = 0; struct mips64_pracc_context ctx; int retval; int pass = 0; @@ -243,7 +243,7 @@ int mips64_pracc_exec(struct mips_ejtag *ejtag_info, address_prev = address; else address_prev = 0; - address32 = data = 0; + address32 = 0; mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS); mips_ejtag_drscan_32(ejtag_info, &address32); @@ -1358,8 +1358,6 @@ int mips64_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, 0, NULL, 0, NULL); /* next fetch to dmseg should be in FASTDATA_AREA, check */ - address = 0; - mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS); retval = mips_ejtag_drscan_32(ejtag_info, &address32); if (retval != ERROR_OK) @@ -1411,7 +1409,6 @@ int mips64_pracc_fastdata_xfer(struct mips_ejtag *ejtag_info, return retval; } - address = 0; mips_ejtag_set_instr(ejtag_info, EJTAG_INST_ADDRESS); retval = mips_ejtag_drscan_32(ejtag_info, &address32); if (retval != ERROR_OK) { -- 2.30.2